Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MD] Create data source menu component able to be mount to nav bar #6082

Merged
merged 2 commits into from
Mar 8, 2024

Conversation

BionIT
Copy link
Collaborator

@BionIT BionIT commented Mar 8, 2024

Description

This change add a new data source menu component which exposes function to allow plugins to consume and mount to the navigation bar.

Issues Resolved

This PR is to expose component without backporting to release branch yet.

Screenshot

dsmenu.mp4

Testing the changes

The following steps were performed in the recording above

  1. enable data source plugin
  2. go to search relevance and see the mounted data source menu, selected option to be data sources which is passed in via selectedOption
  3. set to disable the menu will make the menu unclickable
  4. go to query workbench and see the mounted data source menu, selected a data source and make query, will see the results from data source

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: Lu Yu <nluyu@amazon.com>
Signed-off-by: Lu Yu <nluyu@amazon.com>
Copy link

codecov bot commented Mar 8, 2024

Codecov Report

Attention: Patch coverage is 47.91667% with 25 lines in your changes are missing coverage. Please review.

Project coverage is 67.13%. Comparing base (144c022) to head (59fcc11).

Files Patch % Lines
...onents/data_source_menu/data_source_selectable.tsx 40.00% 16 Missing and 2 partials ⚠️
...c/components/data_source_menu/data_source_menu.tsx 56.25% 2 Missing and 5 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6082   +/-   ##
=======================================
  Coverage   67.13%   67.13%           
=======================================
  Files        3318     3321    +3     
  Lines       64037    64085   +48     
  Branches    10266    10280   +14     
=======================================
+ Hits        42990    43025   +35     
- Misses      18549    18555    +6     
- Partials     2498     2505    +7     
Flag Coverage Δ
Linux_1 31.63% <ø> (ø)
Linux_2 55.20% <ø> (ø)
Linux_3 ?
Linux_4 35.10% <2.08%> (-0.05%) ⬇️
Windows_1 31.68% <ø> (+0.02%) ⬆️
Windows_2 55.17% <ø> (ø)
Windows_3 44.61% <47.91%> (+<0.01%) ⬆️
Windows_4 35.10% <2.08%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BionIT BionIT added the multiple datasource multiple datasource project label Mar 8, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 25, 2024
…6082)

* create data source menu component

Signed-off-by: Lu Yu <nluyu@amazon.com>

* add changelog

Signed-off-by: Lu Yu <nluyu@amazon.com>

---------

Signed-off-by: Lu Yu <nluyu@amazon.com>
(cherry picked from commit ae437b9)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
BionIT pushed a commit that referenced this pull request Mar 25, 2024
…6082) (#6258)

* create data source menu component

Signed-off-by: Lu Yu <nluyu@amazon.com>

* add changelog

Signed-off-by: Lu Yu <nluyu@amazon.com>

---------

Signed-off-by: Lu Yu <nluyu@amazon.com>
(cherry picked from commit ae437b9)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants