Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused java11 gradle configuration #11661

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

andrross
Copy link
Member

The java11-specific sources were removed back in #2898 and as far as I can tell this configuration has been unneeded since that point.

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

The java11-specific sources were removed back in opensearch-project#2898 and as far as I
can tell this configuration has been unneeded since that point.

Signed-off-by: Andrew Ross <andrross@amazon.com>
Copy link
Contributor

Compatibility status:

Checks if related components are compatible with change bbc7258

Incompatible components

Incompatible components: [https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/performance-analyzer-rca.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/k-nn.git]

Copy link
Contributor

❕ Gradle check result for bbc7258: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.action.admin.cluster.node.tasks.ResourceAwareTasksTests.testTaskResourceTrackingDuringTaskCancellation

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Dec 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2c8ee19) 71.46% compared to head (bbc7258) 71.27%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #11661      +/-   ##
============================================
- Coverage     71.46%   71.27%   -0.19%     
+ Complexity    59257    59132     -125     
============================================
  Files          4906     4906              
  Lines        278184   278184              
  Branches      40421    40421              
============================================
- Hits         198791   198272     -519     
- Misses        62959    63423     +464     
- Partials      16434    16489      +55     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reta
Copy link
Collaborator

reta commented Dec 21, 2023

Thanks @andrross !

@reta reta merged commit a3524b3 into opensearch-project:main Dec 21, 2023
84 of 111 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Dec 21, 2023
The java11-specific sources were removed back in #2898 and as far as I
can tell this configuration has been unneeded since that point.

Signed-off-by: Andrew Ross <andrross@amazon.com>
(cherry picked from commit a3524b3)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@andrross andrross deleted the remove-java11 branch December 21, 2023 21:51
andrross added a commit to andrross/OpenSearch that referenced this pull request Dec 21, 2023
This is the same unused java11 configuration that was removed from the
server module in opensearch-project#11661.

Signed-off-by: Andrew Ross <andrross@amazon.com>
andrross added a commit that referenced this pull request Dec 22, 2023
This is the same unused java11 configuration that was removed from the
server module in #11661.

Signed-off-by: Andrew Ross <andrross@amazon.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Dec 22, 2023
This is the same unused java11 configuration that was removed from the
server module in #11661.

Signed-off-by: Andrew Ross <andrross@amazon.com>
(cherry picked from commit f92f846)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
reta pushed a commit that referenced this pull request Dec 22, 2023
)

This is the same unused java11 configuration that was removed from the
server module in #11661.


(cherry picked from commit f92f846)

Signed-off-by: Andrew Ross <andrross@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
reta pushed a commit that referenced this pull request Dec 22, 2023
The java11-specific sources were removed back in #2898 and as far as I
can tell this configuration has been unneeded since that point.


(cherry picked from commit a3524b3)

Signed-off-by: Andrew Ross <andrross@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
rayshrey pushed a commit to rayshrey/OpenSearch that referenced this pull request Mar 18, 2024
The java11-specific sources were removed back in opensearch-project#2898 and as far as I
can tell this configuration has been unneeded since that point.

Signed-off-by: Andrew Ross <andrross@amazon.com>
rayshrey pushed a commit to rayshrey/OpenSearch that referenced this pull request Mar 18, 2024
…roject#11665)

This is the same unused java11 configuration that was removed from the
server module in opensearch-project#11661.

Signed-off-by: Andrew Ross <andrross@amazon.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
The java11-specific sources were removed back in opensearch-project#2898 and as far as I
can tell this configuration has been unneeded since that point.

Signed-off-by: Andrew Ross <andrross@amazon.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
…roject#11665)

This is the same unused java11 configuration that was removed from the
server module in opensearch-project#11661.

Signed-off-by: Andrew Ross <andrross@amazon.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants