Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed java11 source folders since JDK-11 is the baseline now #2898

Merged
merged 1 commit into from
Apr 18, 2022

Conversation

reta
Copy link
Collaborator

@reta reta commented Apr 14, 2022

Signed-off-by: Andriy Redko andriy.redko@aiven.io

Description

Removed java11 source folders since JDK-11 is the baseline now (also unblocks unnecessary Jacoco customizations to workaround jacoco/jacoco#407).

Issues Resolved

Part of https://github.com/opensearch-project/OpenSearch/pull/2821/files

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@reta reta requested a review from a team as a code owner April 14, 2022 16:41
@reta
Copy link
Collaborator Author

reta commented Apr 14, 2022

@dblock please when you have time, thanks!

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 22a18d9c38e1cbe4fdde94c10388d591aa0fcfdd
Log 4479

Reports 4479

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success 0ca2d49
Log 4500

Reports 4500

Copy link
Collaborator

@nknize nknize left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thx!

@reta
Copy link
Collaborator Author

reta commented Apr 18, 2022

@dblock apologies, I could not add labels to backport it to 2.0, may I ask you please to add those?

@saratvemulapalli
Copy link
Member

@reta as a maintainer I believe you should be able to add labels?
@dblock @CEHENKLE

@saratvemulapalli saratvemulapalli added backport 2.0 Backport to 2.0 branch backport 2.x Backport to 2.x branch v3.0.0 Issues and PRs related to version 3.0.0 labels Apr 18, 2022
@saratvemulapalli saratvemulapalli merged commit d61d170 into opensearch-project:main Apr 18, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 18, 2022
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
(cherry picked from commit d61d170)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 18, 2022
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
(cherry picked from commit d61d170)
@reta
Copy link
Collaborator Author

reta commented Apr 18, 2022

@saratvemulapalli you are very right, the labels (and other settings) are available to me now (but were not available before), thanks for highlighting that!

saratvemulapalli pushed a commit that referenced this pull request Apr 18, 2022
#2952)

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
(cherry picked from commit d61d170)

Co-authored-by: Andriy Redko <andriy.redko@aiven.io>
saratvemulapalli pushed a commit that referenced this pull request Apr 18, 2022
#2953)

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
(cherry picked from commit d61d170)

Co-authored-by: Andriy Redko <andriy.redko@aiven.io>
andrross added a commit to andrross/OpenSearch that referenced this pull request Dec 21, 2023
The java11-specific sources were removed back in opensearch-project#2898 and as far as I
can tell this configuration has been unneeded since that point.

Signed-off-by: Andrew Ross <andrross@amazon.com>
reta pushed a commit that referenced this pull request Dec 21, 2023
The java11-specific sources were removed back in #2898 and as far as I
can tell this configuration has been unneeded since that point.

Signed-off-by: Andrew Ross <andrross@amazon.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Dec 21, 2023
The java11-specific sources were removed back in #2898 and as far as I
can tell this configuration has been unneeded since that point.

Signed-off-by: Andrew Ross <andrross@amazon.com>
(cherry picked from commit a3524b3)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
reta pushed a commit that referenced this pull request Dec 22, 2023
The java11-specific sources were removed back in #2898 and as far as I
can tell this configuration has been unneeded since that point.


(cherry picked from commit a3524b3)

Signed-off-by: Andrew Ross <andrross@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
rayshrey pushed a commit to rayshrey/OpenSearch that referenced this pull request Mar 18, 2024
The java11-specific sources were removed back in opensearch-project#2898 and as far as I
can tell this configuration has been unneeded since that point.

Signed-off-by: Andrew Ross <andrross@amazon.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
The java11-specific sources were removed back in opensearch-project#2898 and as far as I
can tell this configuration has been unneeded since that point.

Signed-off-by: Andrew Ross <andrross@amazon.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch backport 2.0 Backport to 2.0 branch v3.0.0 Issues and PRs related to version 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants