-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add implementation for remote store path types #13103
Conversation
Compatibility status:Checks if related components are compatible with change 1c40cf1 Incompatible componentsSkipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/performance-analyzer.git] |
❌ Gradle check result for 326459d: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
server/src/main/java/org/opensearch/indices/IndicesService.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/indices/IndicesService.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/index/remote/RemoteStoreEnums.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Ashish Singh <ssashish@amazon.com>
❕ Gradle check result for d32b501: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
❌ Gradle check result for d07246b: Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Flaky test - #5329 |
Signed-off-by: Ashish Singh <ssashish@amazon.com>
❕ Gradle check result for 1c40cf1: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Flaky test - #6090 |
Signed-off-by: Ashish Singh <ssashish@amazon.com> (cherry picked from commit bad49ef) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Auto backport is failing since the following code is different from main in 2.x branch - main branch OpenSearch/server/src/internalClusterTest/java/org/opensearch/remotestore/RemoteStoreIT.java Lines 842 to 843 in 207bbad
2.x branch OpenSearch/server/src/internalClusterTest/java/org/opensearch/remotestore/RemoteStoreIT.java Line 853 in aa50a60
Raising manual backport. |
* Add implementation for remote store path types (#13103) Signed-off-by: Ashish Singh <ssashish@amazon.com> * Fix testLocalOnlyTranslogCleanupOnNodeRestart due to code differences Signed-off-by: Ashish Singh <ssashish@amazon.com> --------- Signed-off-by: Ashish Singh <ssashish@amazon.com>
Description
This is one of the tasks to achieve #12589 as part of the feature request #12567. This is only an increment step to conclude the optimised prefix path work proposed in the feature request.
In this PR, we are getting following things done -
hashed_prefix
as the default path type.hashed_infix
. This can be used to keep the data confined for a cluster within the base path supplied by the user.Related Issues
Resolves #13074
Check List
[ ] Commit changes are listed out in CHANGELOG.md file (See: Changelog)[ ] Public documentation issue/PR createdBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.