-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sure processPostCollection is called in case of early termination #14208
Conversation
❌ Gradle check result for 1b91933: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Jay Deng <jayd0104@gmail.com>
❕ Gradle check result for c56c693: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14208 +/- ##
============================================
+ Coverage 71.42% 71.73% +0.30%
- Complexity 59978 62059 +2081
============================================
Files 4985 5117 +132
Lines 282275 291683 +9408
Branches 40946 42165 +1219
============================================
+ Hits 201603 209225 +7622
- Misses 63999 65212 +1213
- Partials 16673 17246 +573 ☔ View full report in Codecov by Sentry. |
opensearch-project#14208) Signed-off-by: Jay Deng <jayd0104@gmail.com>
opensearch-project#14208) Signed-off-by: Jay Deng <jayd0104@gmail.com>
opensearch-project#14208) (opensearch-project#14213) (cherry picked from commit 5093901) Signed-off-by: Jay Deng <jayd0104@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: kkewwei <kkewwei@163.com>
opensearch-project#14208) Signed-off-by: Jay Deng <jayd0104@gmail.com>
Description
Make sure processPostCollection is still called when early termination kicks in.
Related Issues
Resolves #14198
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.