Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a maintainers file based on the maintainers list that CEHENKLE posted #523

Merged
merged 1 commit into from
Apr 13, 2021

Conversation

geekygirldawn
Copy link
Contributor

As @ke4qqq suggested, I converted the list of current maintainers found in this forum post for the OpenSearch section to a new maintainers file.

If this looks good and is merged, I can do something similar in the OpenSearch Dashboards repo.

As I mentioned in the forums, I'm also happy to help out with governance and related docs like this one :)

Signed-off-by: Dawn M. Foster fosterd@vmware.com

@odfe-release-bot
Copy link

✅   Gradle Wrapper Validation success b0386158681f168eeb96ab9e159bed9982381948

@odfe-release-bot
Copy link

✅   DCO Check Passed b0386158681f168eeb96ab9e159bed9982381948

@odfe-release-bot
Copy link

✅   Gradle Precommit success b0386158681f168eeb96ab9e159bed9982381948

@nknize
Copy link
Collaborator

nknize commented Apr 12, 2021

As I mentioned in the forums, I'm also happy to help out with governance and related docs like this one :)

Thank you @geekygirldawn Super helpful to have these contributions! I love this as a start.

What do you think about adding a notation for contributors that are also Lucene committers / contributors (since Lucene is really the brains of the search) to highlight broader community involvement?

@nknize
Copy link
Collaborator

nknize commented Apr 12, 2021

start gradle check

@odfe-release-bot
Copy link

✅   Gradle Check success b0386158681f168eeb96ab9e159bed9982381948
Log 62

Reports 62

Copy link
Member

@CEHENKLE CEHENKLE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Collaborator

@nknize nknize left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm definitely good with this as the start! I am curious some thoughts on highlighting the Lucene contribution side (committers) to show sustained commitment to the core search API. We can always do that as a follow up, but I don't want to close the PR without capturing some of those thoughts here.

@nknize nknize self-requested a review April 12, 2021 18:35
@geekygirldawn
Copy link
Contributor Author

I'm definitely good with this as the start! I am curious some thoughts on highlighting the Lucene contribution side (committers) to show sustained commitment to the core search API. We can always do that as a follow up, but I don't want to close the PR without capturing some of those thoughts here.

Typically, the maintainers file would just contain the maintainers for this particular repo. This helps new contributors understand who is likely to merge their PRs and gives them real people to follow up with if there are any issues getting their contributions merged. It might make sense to have another doc if you wanted to highlight contributions to Lucene?

@odfe-release-bot
Copy link

✅   Gradle Wrapper Validation success d229e466589fbf4e8294d4b95fa882ef6c1ed006

@odfe-release-bot
Copy link

❌   DCO Check Failed d229e466589fbf4e8294d4b95fa882ef6c1ed006
Run ./dev-tools/signoff-check.sh remotes/origin/main d229e466589fbf4e8294d4b95fa882ef6c1ed006 to check locally
Use git commit with -s to add 'Signed-of-by: {EMAIL}' on impacted commits

@odfe-release-bot
Copy link

✅   Gradle Precommit success d229e466589fbf4e8294d4b95fa882ef6c1ed006

@odfe-release-bot
Copy link

✅   Gradle Wrapper Validation success 93e3e7e7fbc97433ace90675b46074549ffe557b

@odfe-release-bot
Copy link

❌   DCO Check Failed 93e3e7e7fbc97433ace90675b46074549ffe557b
Run ./dev-tools/signoff-check.sh remotes/origin/main 93e3e7e7fbc97433ace90675b46074549ffe557b to check locally
Use git commit with -s to add 'Signed-of-by: {EMAIL}' on impacted commits

@odfe-release-bot
Copy link

✅   Gradle Wrapper Validation success d2afc90

@odfe-release-bot
Copy link

✅   DCO Check Passed d2afc90

@odfe-release-bot
Copy link

✅   Gradle Precommit success 93e3e7e7fbc97433ace90675b46074549ffe557b

@odfe-release-bot
Copy link

✅   Gradle Precommit success d2afc90

@nknize
Copy link
Collaborator

nknize commented Apr 12, 2021

start gradle check

@odfe-release-bot
Copy link

❌   Gradle Check failure d2afc90
Log 65

Reports 65

@alolita
Copy link

alolita commented Apr 13, 2021

@nknize @CEHENKLE you may consider taking a look at contributor roles used in OpenTelemetry - https://github.com/open-telemetry/community/blob/main/community-membership.md as well as using a CODEOWNERS file in each repo. See https://docs.github.com/en/github/creating-cloning-and-archiving-repositories/about-code-owners

@adnapibar
Copy link
Contributor

start gradle check

@odfe-release-bot
Copy link

✅   Gradle Check success d2afc90
Log 68

Reports 68

@geekygirldawn geekygirldawn deleted the maintainers branch April 21, 2021 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants