Adding core changes for API to check per awareness attribute health #5231

nishchay21 · 2022-11-12T11:25:54Z

Signed-off-by: Nishchay Malhotra nishcha@amazon.com

Description

The PR solves issue #5230. It adds the capability of new API where one can view per awareness attribute health status. As of today opensearch only shows health for full cluster however health per awareness attribute is still not seen. Added an API today monitor the cluster availability status per awareness attribute as that would give use more information on how many shards are assigned per awareness attribute value, how many nodes are distributes per awareness attribute value etc. Follwoing things can be shown per awareness attribute value [eg rack as attribute]:

Total number of nodes per rack
Total shards per rack.
Weights given per rack if defined.
If "cluster.routing.allocation.awareness.balance" is enforced we can also predict the unassigned shards.

Issues Resolved

#5230.

Check List

New functionality includes testing.
All tests pass
New functionality has been documented.
New functionality has javadoc added
Commits are signed per the DCO using --signoff
Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

github-actions · 2022-11-12T11:55:38Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/6836/
CommitID: 0150fae
Please examine the workflow log, locate, and copy-paste the failure below, then iterate to green.
Is the failure a flaky test unrelated to your change?

github-actions · 2022-11-12T12:29:35Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/6837/
CommitID: 43287ba
Please examine the workflow log, locate, and copy-paste the failure below, then iterate to green.
Is the failure a flaky test unrelated to your change?

github-actions · 2022-11-14T05:58:31Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/6851/
CommitID: fcdf5df

codecov-commenter · 2022-11-14T06:00:19Z

Codecov Report

Merging #5231 (31d4061) into main (da94dbb) will decrease coverage by 0.14%.
The diff coverage is 76.92%.

@@             Coverage Diff              @@
##               main    #5231      +/-   ##
============================================
- Coverage     71.09%   70.94%   -0.15%     
+ Complexity    58499    58476      -23     
============================================
  Files          4748     4751       +3     
  Lines        278818   279104     +286     
  Branches      40296    40341      +45     
============================================
- Hits         198219   198015     -204     
- Misses        64477    64918     +441     
- Partials      16122    16171      +49

Impacted Files	Coverage Δ
...luster/awarenesshealth/ClusterAwarenessHealth.java	`57.14% <57.14%> (ø)`
...sshealth/ClusterAwarenessAttributeValueHealth.java	`76.33% <76.33%> (ø)`
...renesshealth/ClusterAwarenessAttributesHealth.java	`81.88% <81.88%> (ø)`
...n/indices/forcemerge/ForceMergeRequestBuilder.java	`0.00% <0.00%> (-75.00%)`	⬇️
...a/org/opensearch/client/cluster/ProxyModeInfo.java	`0.00% <0.00%> (-60.00%)`	⬇️
...ava/org/opensearch/action/NoSuchNodeException.java	`0.00% <0.00%> (-50.00%)`	⬇️
...a/org/opensearch/tasks/TaskCancelledException.java	`50.00% <0.00%> (-50.00%)`	⬇️
...ain/java/org/opensearch/search/sort/MinAndMax.java	`63.15% <0.00%> (-36.85%)`	⬇️
.../opensearch/client/indices/CloseIndexResponse.java	`56.25% <0.00%> (-35.00%)`	⬇️
.../indices/forcemerge/TransportForceMergeAction.java	`25.00% <0.00%> (-33.34%)`	⬇️
... and 479 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

imRishN

Changes in rest-api-spec is missing

imRishN · 2022-11-16T07:21:33Z

server/src/main/java/org/opensearch/rest/action/admin/cluster/RestClusterHAHealthAction.java

+
+    @Override
+    public List<Route> routes() {
+        return List.of(new Route(GET, "/_cluster/ha_health"));


HA sounds like too specific and many users might not relate with it. Shall we call it verbose_health or something similar?

We did finalize this during the discussions however ha sounds better to me . I will let bukhtawar and gaurav comment on this if required I can change that,.

imRishN · 2022-11-16T07:24:49Z

...c/main/java/org/opensearch/action/admin/cluster/hahealth/TransportClusterHaHealthAction.java

+
+    @Override
+    protected void clusterManagerOperation(
+        final Task task,


Where is this task used?

I have kept that if we need for future use and on debug level we can log the taskID if needed

imRishN · 2022-11-17T06:01:16Z

server/src/main/java/org/opensearch/action/admin/cluster/hahealth/ClusterHaHealthRequest.java

+ *
+ * @opensearch.internal
+ */
+public class ClusterHaHealthRequest extends ClusterManagerNodeReadRequest<ClusterHaHealthRequest> {


Can we rather extend from ClusterHealthRequest? That might help to get the capabilities of generic health requests like specifying indices, wait for status, etc. Although those extensions can be taken up in a subsequent PR

I thought so but than segregating it seems better because if tomorrow we need to add new capabilities to this API itself would be better and more easy. So thinking in terms of single responsibility model per class this seems better to me.

imRishN · 2022-11-17T06:05:26Z

server/src/main/java/org/opensearch/action/admin/cluster/hahealth/ClusterHaHealthResponse.java

+
+    private static final String CLUSTER_NAME = "clusterName";
+    private static final String STATUS = "domainHealth";
+    private static final String NUMBER_OF_NODES = "totalNodes";
+    private static final String NUMBER_OF_DATA_NODES = "totalDataNodes";
+    private static final String ACTIVE_SHARDS = "totalShards";
+    private static final String UNASSIGNED_SHARDS = "totalUnassignedShards";
+    private static final String INITIALIZING_SHARDS = "totalInitializingShards";
+    private static final String AWARENESS_ATTRIBUTE = "AwarenessAttribute";


Most of these variables also present in ClusterHealthResponse with the only change is awareness attribute health. If it is just about adding one map in regular health check call, shall we just rather add query param in the health check call which would return more verbose health like here rather than build a new API altogether? Something like ?verbose_health

What do you think?

Same as above. As cluster health is aggregation for cluster and not awareness attribute specific would be better to segregate this.

imRishN · 2022-11-17T06:06:05Z

server/src/main/java/org/opensearch/action/admin/cluster/hahealth/ClusterHaHealthResponse.java

+        builder.field(ACTIVE_SHARDS, getActiveShards());
+        builder.field(UNASSIGNED_SHARDS, getUnassignedShards());
+        builder.field(INITIALIZING_SHARDS, getInitializingShards());
+        builder.field(AWARENESS_ATTRIBUTE, getAwarenessAttributeHealth());


This field is the only difference between regular cluster health and this new API

builder.field(AWARENESS_ATTRIBUTE, getAwarenessAttributeHealth());

Same as above

github-actions · 2022-11-17T12:03:18Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/6992/
CommitID: fcdf5df

dblock · 2022-11-17T17:52:45Z

CHANGELOG.md

@@ -68,6 +68,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),

 ## [Unreleased 2.x]
 ### Added
+- Added feature to check per awareness attribute value health([#5231](https://github.com/opensearch-project/OpenSearch/pull/5231))


I think we're adding a new API here, so it's not a "feature to check", no?

Make sense will make that change

Bukhtawar · 2022-11-21T06:08:57Z

server/src/main/java/org/opensearch/action/admin/cluster/hahealth/ClusterHaHealthAction.java

+ *
+ * @opensearch.internal
+ */
+public class ClusterHaHealthAction extends ActionType<ClusterHaHealthResponse> {


Can we rename this to ClusterAwarenessHealthAction

Will make the change

Bukhtawar · 2022-11-21T06:09:10Z

server/src/main/java/org/opensearch/action/admin/cluster/hahealth/ClusterHaHealthAction.java

+public class ClusterHaHealthAction extends ActionType<ClusterHaHealthResponse> {
+
+    public static final ClusterHaHealthAction INSTANCE = new ClusterHaHealthAction();
+    public static final String NAME = "cluster:monitor/ha_health";


nit: awareness_health

Bukhtawar · 2022-11-21T18:28:00Z

server/src/main/java/org/opensearch/cluster/hahealth/ClusterHaHealth.java

+     * @param clusterState The current cluster state. Must not be null.
+     * @param clusterSettings the current cluster settings.
+     */
+    public ClusterHaHealth(ClusterState clusterState, ClusterSettings clusterSettings) {


The constructor is just too big, would prefer smaller methods

Will make this as small methods

Added smaller methods

github-actions · 2022-11-22T13:52:09Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/7214/
CommitID: d6fd61b
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

github-actions · 2022-11-22T14:08:19Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/7215/
CommitID: 49ac78f
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

github-actions · 2022-11-22T14:42:01Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/7216/
CommitID: 6371fc5
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

gbbafna · 2022-11-28T16:22:51Z

server/src/main/java/org/opensearch/client/ClusterAdminClient.java

@@ -205,6 +207,15 @@ public interface ClusterAdminClient extends OpenSearchClient {
     */
    void state(ClusterStateRequest request, ActionListener<ClusterStateResponse> listener);

+    /**
+     * The ha_health of the cluster.


s/ha_health/awareness_health/g

gbbafna · 2022-11-29T04:11:25Z

server/src/main/java/org/opensearch/cluster/awarenesshealth/ClusterAwarenessHealth.java

+        // Getting the awareness attribute list
+        List<String> awarenessAttributeList = clusterSettings.get(
+            AwarenessAllocationDecider.CLUSTER_ROUTING_ALLOCATION_AWARENESS_ATTRIBUTE_SETTING
+        );
+
+        // Getting the replicaEnforcement settings as both are necessary for replica enforcement.
+        boolean replicaEnforcement = clusterSettings.get(AwarenessReplicaBalance.CLUSTER_ROUTING_ALLOCATION_AWARENESS_BALANCE_SETTING);
+        Settings forcedAwarenessSettings = clusterSettings.get(
+            AwarenessAllocationDecider.CLUSTER_ROUTING_ALLOCATION_AWARENESS_FORCE_GROUP_SETTING
+        );


Lets add a validator which validates for following things

CLUSTER_ROUTING_ALLOCATION_AWARENESS_ATTRIBUTE_SETTING

CLUSTER_ROUTING_ALLOCATION_AWARENESS_FORCE_GROUP_SETTING

replicaEnforcement

Single attribute only (two attributes like zone and rack are not supported)

If validation fails, we can do either of these

[Preferred] Throw an exception

Not populate ZoneHealth

As discussed we will through empty map and not exception so not moving the same to validator

gbbafna · 2022-11-29T04:18:44Z

server/src/main/java/org/opensearch/cluster/awarenesshealth/ClusterAwarenessHealth.java

+        );
+    }
+
+    private ClusterHealthStatus generateIndexAndStateStats(ClusterState clusterState) {


can we reuse TransportClusterHealthAction to do most of the heavy lifting here ? I did a quick POC earlier : https://github.com/gbbafna/admin-plugin/blob/main/src/main/java/org/opensearch/path/to/plugin/TransportClusterHAHealthAction.java#L113 . The benefits are two fold

Any evolution of cluster health can be reused .

Cluster Health is much more complex and provides option to wait for unassigned shards etc . We can reuse that later if needed .

This was done on consistency standpoint so that the state on full call is not changed. Will check if we can reuse the class

lets populate status as well in here and rename to setClusterHealth .

gbbafna · 2022-11-29T05:20:07Z

server/src/main/java/org/opensearch/cluster/awarenesshealth/ClusterAwarenessHealth.java

+    private int unassignedShards;
+    private int initializingShards;
+    private ClusterHealthStatus status;
+    private final Map<String, Object> collatedAttributeHealth;


Instead of Object, lets created AttributeHealth class.

As discussed we are having multiple attribute value and per attribute value we are returning a list of Attribute values so instead of object class AttributeHealth class cannot be used

gbbafna · 2022-11-29T05:38:19Z

server/src/main/java/org/opensearch/cluster/awarenesshealth/ClusterAwarenessHealth.java

+    private int activeShards;
+    private int unassignedShards;
+    private int initializingShards;


lets add relocating shards as well .

github-actions · 2022-11-30T11:07:46Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/7430/
CommitID: e7d9c3b
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

github-actions · 2022-11-30T12:52:16Z

Gradle Check (Jenkins) Run Completed with:

RESULT: TIMEOUT ❌
URL: https://build.ci.opensearch.org/job/gradle-check/7431/
CommitID: 180a124
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

anshu1106 · 2022-11-30T14:48:42Z

server/src/main/java/org/opensearch/cluster/awarenesshealth/ClusterAwarenessHealth.java

+        return shardAllocationPerNode;
+    }
+
+    private Map<String, Object> generateAwarenessAttributeHealthMap(


Is it possible to break this function for better code readability?

github-actions · 2022-12-01T07:18:35Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/7475/
CommitID: d2c00d1
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

github-actions · 2022-12-01T07:20:12Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/7476/
CommitID: 1ae9406
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

github-actions · 2022-12-01T07:40:47Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/7477/
CommitID: 9b5101f
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

github-actions · 2022-12-01T07:52:22Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/7479/
CommitID: 9b3d294
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

github-actions · 2022-12-01T08:29:09Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/7480/
CommitID: aea4655
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

github-actions · 2022-12-01T09:18:25Z

Gradle Check (Jenkins) Run Completed with:

RESULT: UNSTABLE ❕
TEST FAILURES:

      1 org.opensearch.index.ShardIndexingPressureConcurrentExecutionTests.testReplicaThreadedUpdateToShardLimitsAndRejections

URL: https://build.ci.opensearch.org/job/gradle-check/7483/
CommitID: 34410f6
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

github-actions · 2022-12-01T13:08:36Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/7490/
CommitID: 08e1825
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

github-actions · 2022-12-01T14:02:34Z

Gradle Check (Jenkins) Run Completed with:

RESULT: UNSTABLE ❕
TEST FAILURES:

      1 org.opensearch.index.ShardIndexingPressureConcurrentExecutionTests.testReplicaThreadedUpdateToShardLimitsAndRejections

URL: https://build.ci.opensearch.org/job/gradle-check/7492/
CommitID: 7a9714a
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

github-actions · 2022-12-30T06:24:11Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/8617/
CommitID: 75a0ac3

Bukhtawar · 2023-01-02T17:29:03Z

...c/main/java/org/opensearch/cluster/awarenesshealth/ClusterAwarenessAttributeValueHealth.java

+    }
+
+    // Constructor use by Unit test case.
+    public ClusterAwarenessAttributeValueHealth(


Make all places have package private usages if used solely for tests

Bukhtawar · 2023-01-02T17:32:28Z

...c/main/java/org/opensearch/cluster/awarenesshealth/ClusterAwarenessAttributeValueHealth.java

+     *
+     * @param name name of awareness attribute
+     */
+    public ClusterAwarenessAttributeValueHealth(String name) {


Can't we pass the list of RoutingNode with the same attribute value?

Bukhtawar · 2023-01-02T17:35:28Z

...c/main/java/org/opensearch/cluster/awarenesshealth/ClusterAwarenessAttributeValueHealth.java

+        String nodeId;
+
+        // computing active, relocating and initializing shards info
+        for (ShardRouting shard : clusterState.routingTable().allShards()) {


We don't need to iterate over all shards for all distinct attribute value, its a wasted computation. Instead we could filter the RoutingNode for this attribute value and pass it in the the ctor and iterate over only those set of nodes. This would also avoid the check for nodeInCurrentAZ

Bukhtawar · 2023-01-02T17:36:36Z

...r/src/main/java/org/opensearch/cluster/awarenesshealth/ClusterAwarenessAttributesHealth.java

+                        attributeValue = nodeAttributes.get(awarenessAttributeName);
+
+                        if (!attributesHealth.containsKey(attributeValue)) {
+                            clusterAwarenessAttributeValueHealth = new ClusterAwarenessAttributeValueHealth(attributeValue);


Lets pass the RoutingNode here to avoid unnecessary computation

computation will still exists in the parent class . However will make the required change

Bukhtawar · 2023-01-02T17:50:53Z

...r/src/main/java/org/opensearch/cluster/awarenesshealth/ClusterAwarenessAttributesHealth.java

+
+        // This is the map that would store all the stats per attribute ie
+        // health stats for rack-1, rack-2 etc.
+        awarenessAttributeValueHealthMap = new HashMap<>(Collections.emptyMap());


Remove Collections.emptyMap()?

Signed-off-by: Nishchay Malhotra <nishcha@amazon.com>

github-actions · 2023-01-03T06:07:56Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/8715/
CommitID: 141af1c

Bukhtawar · 2023-01-03T06:14:26Z

...c/main/java/org/opensearch/cluster/awarenesshealth/ClusterAwarenessAttributeValueHealth.java

+        double attributeWeight = 1.0;
+        if (weightedRoutingMetadata != null) {
+            WeightedRouting weightedRouting = weightedRoutingMetadata.getWeightedRouting();
+            attributeWeight = weightedRouting.weights().getOrDefault(name, 1.0);


Not sure if we should default to 1 if no weights specified

Then this would mean that all values are active and no specific parameter is set

Bukhtawar

Thanks @nishchay21, on a high level the changes look good to me. Can you also run this through @gbbafna once more to see if this looks good.

github-actions · 2023-01-03T06:29:21Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/8719/
CommitID: 31d4061

gbbafna

LGTM. Two nit comments regarding naming .

gbbafna · 2023-01-03T13:46:08Z

...r/src/main/java/org/opensearch/cluster/awarenesshealth/ClusterAwarenessAttributesHealth.java

@@ -54,20 +56,20 @@ public ClusterAwarenessAttributesHealth(

        // This is the Map which is storing the per attribute value health stats.
        // The key would be the attribute value like rack-1 and the stats would be stored as value.
-        Map<String, ClusterAwarenessAttributeValueHealth> attributesHealth = new HashMap<>();
+        Map<String, List<String>> attributesHealth = new HashMap<>();


lets rename this as this doesn't consists of health , but list of nodes node. Edit the comment above as well.

gbbafna · 2023-01-03T13:49:40Z

...r/src/main/java/org/opensearch/cluster/awarenesshealth/ClusterAwarenessAttributesHealth.java

@@ -94,7 +93,7 @@ public ClusterAwarenessAttributesHealth(
    }

    private void setClusterAwarenessAttributeValue(
-        Map<String, ClusterAwarenessAttributeValueHealth> perAttributeValueHealthMap,
+        Map<String, List<String>> perAttributeValueHealthMap,


nit : rename here as well .

Signed-off-by: Nishchay Malhotra <nishcha@amazon.com>

github-actions · 2023-01-03T15:14:33Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/8733/
CommitID: dd4e775

…5231) * Adding core changes for API to check per awareness attribute health. Signed-off-by: Nishchay Malhotra <nishcha@amazon.com> (cherry picked from commit 7578cd8) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

…5231) (#5688) * Adding core changes for API to check per awareness attribute health. Signed-off-by: Nishchay Malhotra <nishcha@amazon.com>

…5231) * Adding core changes for API to check per awareness attribute health. Signed-off-by: Nishchay Malhotra <nishcha@amazon.com> (cherry picked from commit 7578cd8) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

…5231) (#5776) * Adding core changes for API to check per awareness attribute health. Signed-off-by: Nishchay Malhotra <nishcha@amazon.com> (cherry picked from commit 7578cd8) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Nishchay Malhotra <nishcha@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

…5231) (#5688) * Adding core changes for API to check per awareness attribute health. Signed-off-by: Nishchay Malhotra <nishcha@amazon.com>

nishchay21 requested review from a team and reta as code owners November 12, 2022 11:25

imRishN reviewed Nov 17, 2022

View reviewed changes

nishchay21 closed this Nov 17, 2022

nishchay21 reopened this Nov 17, 2022

dblock reviewed Nov 17, 2022

View reviewed changes

nishchay21 changed the title ~~Add feature to check per awareness attribute value health.~~ Add API to check per awareness attribute value health. Nov 17, 2022

Bukhtawar reviewed Nov 21, 2022

View reviewed changes

gbbafna reviewed Nov 29, 2022

View reviewed changes

anshu1106 reviewed Nov 30, 2022

View reviewed changes

nishchay21 force-pushed the awareness-health-api branch from 1ae9406 to 9b5101f Compare December 1, 2022 07:06

nishchay21 force-pushed the awareness-health-api branch from 9b5101f to 9b3d294 Compare December 1, 2022 07:31

Bukhtawar mentioned this pull request Dec 31, 2022

Adding @gbbafna to OpenSearch maintainers #5668

Merged

2 tasks

Bukhtawar reviewed Jan 2, 2023

View reviewed changes

nishchay21 added 2 commits January 3, 2023 11:07

Changing shard info calculation logic

141af1c

Signed-off-by: Nishchay Malhotra <nishcha@amazon.com>

Changing shard info calculation logic

31d4061

Signed-off-by: Nishchay Malhotra <nishcha@amazon.com>

Bukhtawar reviewed Jan 3, 2023

View reviewed changes

gbbafna approved these changes Jan 3, 2023

View reviewed changes

Changing variable names

dd4e775

Signed-off-by: Nishchay Malhotra <nishcha@amazon.com>

Bukhtawar approved these changes Jan 3, 2023

View reviewed changes

Bukhtawar merged commit 7578cd8 into opensearch-project:main Jan 3, 2023

gbbafna added the backport 2.x Backport to 2.x branch label Jan 4, 2023

opensearch-trigger-bot bot mentioned this pull request Jan 4, 2023

[Backport 2.x] Adding core changes for API to check per awareness attribute health #5688

Merged

This was referenced Jan 4, 2023

Awareness health api rest and transport layer changes #5694

Merged

Adding awareness health api rest and transport layer changes #5726

Closed

gbbafna pushed a commit that referenced this pull request Jan 9, 2023

Adding core changes for API to check per awareness attribute health (#…

be51d7b

…5231) (#5688) * Adding core changes for API to check per awareness attribute health. Signed-off-by: Nishchay Malhotra <nishcha@amazon.com>

gbbafna added the backport 2.5 label Jan 10, 2023

opensearch-trigger-bot bot mentioned this pull request Jan 10, 2023

[Backport 2.5] Adding core changes for API to check per awareness attribute health #5776

Merged

nishchay21 mentioned this pull request Jan 13, 2023

[Meta] Cluster health api to support awareness attribute level health #5851

Closed

4 tasks

Adding core changes for API to check per awareness attribute health #5231

Adding core changes for API to check per awareness attribute health #5231

Conversation

nishchay21 commented Nov 12, 2022 • edited Loading

Description

Issues Resolved

Check List

github-actions bot commented Nov 12, 2022

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Nov 12, 2022

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Nov 14, 2022

Gradle Check (Jenkins) Run Completed with:

codecov-commenter commented Nov 14, 2022 • edited Loading

Codecov Report

imRishN left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nishchay21 Nov 17, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nishchay21 Nov 17, 2022 • edited Loading

Choose a reason for hiding this comment

imRishN Nov 17, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Nov 17, 2022

Gradle Check (Jenkins) Run Completed with:

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Nov 22, 2022

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Nov 22, 2022

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Nov 22, 2022

Gradle Check (Jenkins) Run Completed with:

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nishchay21 Nov 29, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Nov 30, 2022

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Nov 30, 2022

Gradle Check (Jenkins) Run Completed with:

anshu1106 Nov 30, 2022 • edited Loading

Choose a reason for hiding this comment

github-actions bot commented Dec 1, 2022

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Dec 1, 2022

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Dec 1, 2022

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Dec 1, 2022

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Dec 1, 2022

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Dec 1, 2022

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Dec 1, 2022

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Dec 1, 2022

nishchay21 commented Nov 12, 2022 •

edited

Loading

codecov-commenter commented Nov 14, 2022 •

edited

Loading

nishchay21 Nov 17, 2022 •

edited

Loading

nishchay21 Nov 17, 2022 •

edited

Loading

imRishN Nov 17, 2022 •

edited

Loading

nishchay21 Nov 29, 2022 •

edited

Loading

anshu1106 Nov 30, 2022 •

edited

Loading

Bukhtawar Jan 2, 2023 •

edited

Loading