Converted all .asciidoc to .md. #658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ DCO Check Passed 3f0c4b0be51ed1aa936e029649f04940d57822ba |
|
✅ Gradle Wrapper Validation success 3f0c4b0be51ed1aa936e029649f04940d57822ba |
Signed-off-by: dblock <dblock@amazon.com>
dblock
force-pushed
the
ascidoc-to-markdown
branch
from
3f0c4b0
to
3e015c9
Compare
dblock
commented
May 5, 2021
| @@ -1 +0,0 @@ | |||
| CHANGELOG.asciidoc merge=union | |||
There was a problem hiding this comment.
I couldn't find a CHANGELOG.asciidoc, so ...
There was a problem hiding this comment.
Huhn. That's weird. Vestigial I guess?
|
✅ Gradle Wrapper Validation success 3e015c9 |
|
✅ DCO Check Passed 3e015c9 |
|
✅ Gradle Precommit success 3f0c4b0be51ed1aa936e029649f04940d57822ba |
|
✅ Gradle Precommit success 3e015c9 |
CEHENKLE
approved these changes
May 5, 2021
| @@ -1 +0,0 @@ | |||
| CHANGELOG.asciidoc merge=union | |||
There was a problem hiding this comment.
Huhn. That's weird. Vestigial I guess?
|
start gradle check |
dblock
added a commit
that referenced
this pull request
May 6, 2021
Signed-off-by: dblock <dblock@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: dblock dblock@amazon.com
Description
While some of us do love asciidoc for its many claimed awesome features over markdown, none of those features seem to work in "safe" modes, such as GitHub. In such, we are effectively committing documents that are hard to read or unreadable on GitHub. It's time to standardize to the most widely adopted and least common denominator, GitHub-flavored markdown.
For the technically inclined this is what I followed these instructions:
asciidoc -b docbook TESTING.asciidoc.asciidocspews.pandoc -f docbook -t markdown_strict TESTING.xml -o TESTING.md.Check List
--[x] Commits are signed per the DCO using --signoff
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.