Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Better exception handling in search pipelines #7735

Merged

Commits on May 24, 2023

  1. [Bugfix] Better exception handling in search pipelines

    Thanks to @noCharger for reporting a failing negative test case.
    
    Since we were rethrowing exceptions when resolving search pipelines and
    processing search requests, that could end up killing the listener
    thread.
    
    Also, we want to make sure that any exception thrown from search
    pipelines are wrapped in SearchPipelineProcessingException.
    
    Signed-off-by: Michael Froh <froh@amazon.com>
    msfroh committed May 24, 2023
    Configuration menu
    Copy the full SHA
    566abcf View commit details
    Browse the repository at this point in the history
  2. Add changelog entry and unit tests

    Signed-off-by: Michael Froh <froh@amazon.com>
    msfroh committed May 24, 2023
    Configuration menu
    Copy the full SHA
    0fd3610 View commit details
    Browse the repository at this point in the history
  3. Add check on error message for negative test

    Signed-off-by: Michael Froh <froh@amazon.com>
    msfroh committed May 24, 2023
    Configuration menu
    Copy the full SHA
    87ab1b5 View commit details
    Browse the repository at this point in the history
  4. Fix misleading commment in test

    Signed-off-by: Michael Froh <froh@amazon.com>
    msfroh committed May 24, 2023
    Configuration menu
    Copy the full SHA
    681210c View commit details
    Browse the repository at this point in the history