[Bugfix] Better exception handling in search pipelines

[msfroh]

Description

Thanks to @noCharger for reporting a failing negative test case.

Since we were rethrowing exceptions when resolving search pipelines and processing search requests, that could end up killing the listener thread.

Also, we want to make sure that any exception thrown from search pipelines are wrapped in SearchPipelineProcessingException.

Related Issues

N/A

Check List

• [ ] New functionality includes testing.
  • [ ] All tests pass
• [ ] New functionality has been documented.
  • [ ] New functionality has javadoc added
• Commits are signed per the DCO using --signoff
• [ ] Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[noCharger]

Thanks for the instant bugfix. Let's add changelog and also one unit test case for SearchPipelineService.java

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: UNSTABLE ❕
• TEST FAILURES:

      1 org.opensearch.search.backpressure.SearchBackpressureIT.testSearchShardTaskCancellationWithHighCpu
      1 org.opensearch.indices.replication.SegmentReplicationIT.testScrollCreatedOnReplica

• URL: https://build.ci.opensearch.org/job/gradle-check/16220/
• CommitID: 566abcf
  Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

[codecov]

Codecov Report

Merging #7735 (681210c) into main (70b109d) will increase coverage by 0.12%.
The diff coverage is 80.00%.

@@             Coverage Diff              @@
##               main    #7735      +/-   ##
============================================
+ Coverage     70.63%   70.76%   +0.12%     
- Complexity    56099    56162      +63     
============================================
  Files          4680     4680              
  Lines        266083   266085       +2     
  Branches      39074    39074              
============================================
+ Hits         187955   188296     +341     
+ Misses        62187    61808     -379     
- Partials      15941    15981      +40     

Impacted Files	Coverage Δ
...pensearch/action/search/TransportSearchAction.java	70.99% <0.00%> (+0.43%)	⬆️
...nsearch/search/pipeline/SearchPipelineService.java	83.88% <100.00%> (+1.11%)	⬆️

... and 463 files with indirect coverage changes

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: SUCCESS ✅
• URL: https://build.ci.opensearch.org/job/gradle-check/16249/
• CommitID: 0fd3610

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/16250/
• CommitID: 87ab1b5
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: UNSTABLE ❕
• TEST FAILURES:

      1 org.opensearch.indices.replication.SegmentReplicationIT.testScrollCreatedOnReplica

• URL: https://build.ci.opensearch.org/job/gradle-check/16253/
• CommitID: 87ab1b5
  Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/16254/
• CommitID: 681210c
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[msfroh]

Failing tests on Gradle check seem to be related to #7679

(Not exactly the same failure -- this one is failing because the index already exists, which I saw on a previous PR.)

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: UNSTABLE ❕
• TEST FAILURES:

      1 org.opensearch.repositories.s3.S3BlobContainerRetriesTests.testReadRangeBlobWithRetries

• URL: https://build.ci.opensearch.org/job/gradle-check/16258/
• CommitID: 681210c
  Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.