[Backport 2.x] [Bugfix] Better exception handling in search pipelines #7747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* [Bugfix] Better exception handling in search pipelines Thanks to @noCharger for reporting a failing negative test case. Since we were rethrowing exceptions when resolving search pipelines and processing search requests, that could end up killing the listener thread. Also, we want to make sure that any exception thrown from search pipelines are wrapped in SearchPipelineProcessingException. Signed-off-by: Michael Froh <froh@amazon.com> * Add changelog entry and unit tests Signed-off-by: Michael Froh <froh@amazon.com> * Add check on error message for negative test Signed-off-by: Michael Froh <froh@amazon.com> * Fix misleading commment in test Signed-off-by: Michael Froh <froh@amazon.com> --------- Signed-off-by: Michael Froh <froh@amazon.com> (cherry picked from commit cf02b96) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
requested review from
reta,
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
gbbafna,
setiah,
kartg,
kotwanikunal,
mch2,
nknize,
owaiskazi19,
Rishikesh1159,
ryanbogan,
saratvemulapalli,
shwetathareja,
dreamer-89,
tlfeng,
VachaShah and
dbwiddis
as code owners
reta
approved these changes
May 25, 2023
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## 2.x #7747 +/- ##
============================================
+ Coverage 70.49% 70.53% +0.03%
- Complexity 56362 56366 +4
============================================
Files 4663 4663
Lines 267646 267648 +2
Branches 39637 39637
============================================
+ Hits 188680 188780 +100
+ Misses 62662 62569 -93
+ Partials 16304 16299 -5
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport cf02b96 from #7735.