Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Moving zstd out of sanbox and enabling index setting #8336

Merged

Conversation

sarthakaggarwal97
Copy link
Contributor

@sarthakaggarwal97 sarthakaggarwal97 commented Jun 29, 2023

Description

Backporting #7908 to 2.x

Related Issues

Resolves #7805

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@sarthakaggarwal97
Copy link
Contributor Author

@dblock @reta @backslasht created a backport PR for zstd

@sarthakaggarwal97 sarthakaggarwal97 changed the title Backport/backport 7908 to 2.x [Backport 2.x] Moving zstd out of sanbox and enabling index setting Jun 29, 2023
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.remotestore.SegmentReplicationUsingRemoteStoreIT.testReplicaHasDiffFilesThanPrimary
      1 org.opensearch.remotestore.SegmentReplicationUsingRemoteStoreIT.testPressureServiceStats
      1 org.opensearch.remotestore.SegmentReplicationUsingRemoteStoreIT.testPressureServiceStats
      1 org.opensearch.indices.replication.SegmentReplicationRelocationIT.testPrimaryRelocation

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Jul 3, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Jul 3, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Jul 3, 2023

Gradle Check (Jenkins) Run Completed with:

@sarthakaggarwal97 sarthakaggarwal97 force-pushed the backport/backport-7908-to-2.x branch 2 times, most recently from fe7323d to 37ca427 Compare July 3, 2023 10:21
@github-actions
Copy link
Contributor

github-actions bot commented Jul 3, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Jul 3, 2023

Gradle Check (Jenkins) Run Completed with:

Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
@github-actions
Copy link
Contributor

github-actions bot commented Jul 3, 2023

Gradle Check (Jenkins) Run Completed with:

@codecov
Copy link

codecov bot commented Jul 3, 2023

Codecov Report

Merging #8336 (0eea19c) into 2.x (2e5195b) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##                2.x    #8336      +/-   ##
============================================
- Coverage     70.66%   70.61%   -0.06%     
+ Complexity    56948    56924      -24     
============================================
  Files          4718     4717       -1     
  Lines        269771   269782      +11     
  Branches      39887    39887              
============================================
- Hits         190637   190506     -131     
- Misses        62765    62925     +160     
+ Partials      16369    16351      -18     
Impacted Files Coverage Δ
.../index/codec/customcodecs/ZstdCompressionMode.java 86.36% <ø> (ø)
.../codec/customcodecs/ZstdNoDictCompressionMode.java 79.45% <ø> (ø)
...java/org/opensearch/index/engine/EngineConfig.java 98.50% <ø> (ø)
.../java/org/opensearch/index/codec/CodecService.java 100.00% <100.00%> (+11.11%) ⬆️
.../index/codec/customcodecs/Lucene95CustomCodec.java 76.92% <100.00%> (ø)
...customcodecs/Lucene95CustomStoredFieldsFormat.java 72.00% <100.00%> (ø)
...opensearch/index/codec/customcodecs/ZstdCodec.java 100.00% <100.00%> (ø)
...arch/index/codec/customcodecs/ZstdNoDictCodec.java 100.00% <100.00%> (ø)

... and 457 files with indirect coverage changes

@reta reta merged commit 0342349 into opensearch-project:2.x Jul 3, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants