Add MainResponse version override as a cluster setting.

[mch2]

Signed-off-by: Marc Handalian handalm@amazon.com

Description

This PR addresses #693 by using a cluster setting instead of a system property suggested by 814

This setting is intended to be set after a rolling upgrade via the cluster settings API.

PUT /_cluster/settings
{
  "compatibility" : {
    "override_main_response_version" : true
  }
}

It can be turned off with the same request with a value of false.

A default value for this setting may also be configured via opensearch.yml. If not present, it defaults to false.

Issues Resolved

#693

Check List

• New functionality includes testing.
  • All tests pass
• New functionality has been documented.
  • New functionality has javadoc added
• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[opensearch-ci-bot]

✅   DCO Check Passed d694a20722e5fb96bfc5cadf814ff7c841b14a22

[opensearch-ci-bot]

✅   Gradle Wrapper Validation success d694a20722e5fb96bfc5cadf814ff7c841b14a22

[opensearch-ci-bot]

✅   Gradle Precommit success d694a20722e5fb96bfc5cadf814ff7c841b14a22

[peterzhuamazon]

start gradle check

[opensearch-ci-bot]

✅   Gradle Check success d694a20722e5fb96bfc5cadf814ff7c841b14a22
Log 240

Reports 240

[dblock]

LGTM

[mch2]

Made an update here to improve the commit message

[opensearch-ci-bot]

✅   DCO Check Passed eaf0cf2645ebb1af43b3088aa923c0b1fcb9104e

[opensearch-ci-bot]

✅   Gradle Wrapper Validation success eaf0cf2645ebb1af43b3088aa923c0b1fcb9104e

[opensearch-ci-bot]

✅   Gradle Precommit success eaf0cf2645ebb1af43b3088aa923c0b1fcb9104e

[CEHENKLE]

start gradle check

[opensearch-ci-bot]

✅   Gradle Check success eaf0cf2645ebb1af43b3088aa923c0b1fcb9104e
Log 246

Reports 246

[mch2]

@nknize thoughts on this?

[nknize]

this looks great. I just threw one small suggestion so we don't lose the task of removing this in 2.0.0 (which is currently the main branch)

[opensearch-ci-bot]

✅   Gradle Wrapper Validation success 1d959ba

[opensearch-ci-bot]

✅   DCO Check Passed 1d959ba

[opensearch-ci-bot]

✅   Gradle Precommit success 1d959ba

[CEHENKLE]

start gradle check

[opensearch-ci-bot]

✅   Gradle Check success 1d959ba
Log 248

Reports 248

[gittygoo]

just tried using this to connect Kibana with opensearch and getting the following on kibana

This version of Kibana is incompatible with the following Elasticsearch nodes in your cluster: v1.2.4 @ XXX.1.80:9200 (XXX.1.80), v1.2.4 @ XXX.2.133:9200 (XXX.2.133), v1.2.4 @ XXX.0.15:9200 (XXX.0.15)

Note the version v1.2.4 is still being "seen" by kibana, wasnt it supposed to show something like 7.10.xxx ?

When calling a GET on / to opensearch directly i see "version" : { "number" : "7.10.2",

When calling a GET on "/_nodes?filter_path=nodes..version%2Cnodes..http.publish_address%2Cnodes.*.ip" which seems to be the check that kibana is doing then i get the following (note the versions 1.2.4):

{"nodes":{"XXXXXXXXXXXXX":{"ip":"XXXXXXX.2.133","version":"1.2.4","http":{"publish_address":"XXXXXXX.2.133:9200"}},"XXXXXXX":{"ip":"XXXXXXX.0.15","version":"1.2.4","http":{"publish_address":"XXXXXXX.0.15:9200"}},"XXXXXXX":{"ip":"XXXXXXX.1.80","version":"1.2.4","http":{"publish_address":"XXXXXXX.1.80:9200"}}}}

[dblock]

@gittygoo What version of Kibana are you trying to run?

Generally, I wouldn't recommend running any version of Kibana on top of OpenSearch, even if we are able to change the version number returned here, this is an untested combination.

[gittygoo]

@dblock I understand that but i still need to run kibana since there is currently no package of wazuh for opensearch. Hence why i'm trying this. I tried with kibana 7.9 and 7.10.

Either way i guess these numbers should be changed so that this issue is correctly applied to all relevant endpoints

[dblock]

@gittygoo Reopen a new issue? I suspect that changing the version in nodes response is going to do other bad things :(

Note wazuh/wazuh-dashboard-plugins#3644 specifically re:Wazuh