[Feature] Expose term frequency in Painless script score context #9081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gradle Check (Jenkins) Run Completed with:
|
|
Compatibility status: |
noCharger
force-pushed
the
feature-painless-field-stats-louis-dev
branch
from
7aff647
to
421dabc
Compare
Gradle Check (Jenkins) Run Completed with:
|
|
Compatibility status: |
msfroh
reviewed
Aug 3, 2023
server/src/main/java/org/opensearch/index/query/functionscore/TermFrequencyFunction.java
Outdated
Show resolved
Hide resolved
jainankitk
reviewed
Aug 3, 2023
There was a problem hiding this comment.
@noCharger - Changes look good! Since @russcam validated the changes, we can get the PR out of draft mode and add some unit tests
server/src/main/java/org/opensearch/index/query/functionscore/TermFrequencyFunction.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/index/query/functionscore/TermFrequencyFunction.java
Outdated
Show resolved
Hide resolved
noCharger
force-pushed
the
feature-painless-field-stats-louis-dev
branch
from
7278800
to
c7114c9
Compare
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
noCharger
force-pushed
the
feature-painless-field-stats-louis-dev
branch
from
c7114c9
to
854ca55
Compare
|
Compatibility status: |
Gradle Check (Jenkins) Run Completed with:
|
|
Compatibility status: |
|
Compatibility status: |
noCharger
force-pushed
the
feature-painless-field-stats-louis-dev
branch
from
854ca55
to
1c7f13e
Compare
|
Compatibility status: |
Gradle Check (Jenkins) Run Completed with:
|
Unable to reproduce on local dev env |
reta
reviewed
Aug 8, 2023
server/src/main/java/org/opensearch/search/lookup/LeafSearchLookup.java
Outdated
Show resolved
Hide resolved
reta
reviewed
Aug 8, 2023
reta
reviewed
Aug 11, 2023
server/src/main/java/org/opensearch/search/lookup/LeafSearchLookup.java
Outdated
Show resolved
Hide resolved
|
@noCharger looks pretty cool, thank you! |
|
Compatibility status: |
Gradle Check (Jenkins) Run Completed with:
|
msfroh
approved these changes
Aug 23, 2023
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-9081-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 5d3633cbecfaa1cdc4fcf5efd5ed1ec603de5081
# Push it to GitHub
git push --set-upstream origin backport/backport-9081-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.xThen, create a pull request where the |
4 tasks
|
@noCharger, looks like the 2.x backport failed. Can you please create a manual backport PR? |
neetikasinghal
pushed a commit
to neetikasinghal/OpenSearch
that referenced
this pull request
Aug 23, 2023
…nsearch-project#9081) Add the following functions in Painless script score context: * termfreq * tf * totaltermfreq * sumtotaltermfreq Each of these maps to a Lucene value source. Signed-off-by: Louis Chu <clingzhi@amazon.com>
5 tasks
6 tasks
https://github.com/opensearch-project/OpenSearch/actions/runs/5946439300/job/16126992801#step:3:33 CONFLICT (content): Merge conflict in CHANGELOG.md |
noCharger
added a commit
to noCharger/OpenSearch
that referenced
this pull request
Aug 23, 2023
…nsearch-project#9081) Add the following functions in Painless script score context: * termfreq * tf * totaltermfreq * sumtotaltermfreq Each of these maps to a Lucene value source. Signed-off-by: Louis Chu <clingzhi@amazon.com> (cherry picked from commit 5d3633c)
noCharger
added a commit
to noCharger/OpenSearch
that referenced
this pull request
Aug 23, 2023
…nsearch-project#9081) Add the following functions in Painless script score context: * termfreq * tf * totaltermfreq * sumtotaltermfreq Each of these maps to a Lucene value source. Signed-off-by: Louis Chu <clingzhi@amazon.com> (cherry picked from commit 5d3633c)
noCharger
added a commit
to noCharger/OpenSearch
that referenced
this pull request
Aug 23, 2023
…nsearch-project#9081) Add the following functions in Painless script score context: * termfreq * tf * totaltermfreq * sumtotaltermfreq Each of these maps to a Lucene value source. Signed-off-by: Louis Chu <clingzhi@amazon.com> (cherry picked from commit 5d3633c)
5 tasks
|
@noCharger which feels like the snapshot I have of OpenSearch is pointing to older version where the new interface of ScoreScript.Factory is not present. This blocking the development of features in the K-NN plugin. Validated this by building a local distribution of Opensearch core to run the integration tests. |
5 tasks
@navneet1v Which snapshot does the knn plugin employ? I'd get the snapshot from here: https://artifacts.opensearch.org/snapshots/core/opensearch/version>.-SNAPSHOT/opensearch-min--SNAPSHOT-linux-x64-latest.tar.gz For example, the linux one was created at 4:25 PM PST on 08-23-2023. |
5 tasks
austintlee
pushed a commit
to austintlee/OpenSearch
that referenced
this pull request
Aug 25, 2023
…nsearch-project#9081) Add the following functions in Painless script score context: * termfreq * tf * totaltermfreq * sumtotaltermfreq Each of these maps to a Lucene value source. Signed-off-by: Louis Chu <clingzhi@amazon.com>
6 tasks
Gaganjuneja
pushed a commit
to Gaganjuneja/OpenSearch
that referenced
this pull request
Aug 28, 2023
…nsearch-project#9081) Add the following functions in Painless script score context: * termfreq * tf * totaltermfreq * sumtotaltermfreq Each of these maps to a Lucene value source. Signed-off-by: Louis Chu <clingzhi@amazon.com>
Gaganjuneja
pushed a commit
to Gaganjuneja/OpenSearch
that referenced
this pull request
Aug 28, 2023
…nsearch-project#9081) Add the following functions in Painless script score context: * termfreq * tf * totaltermfreq * sumtotaltermfreq Each of these maps to a Lucene value source. Signed-off-by: Louis Chu <clingzhi@amazon.com> Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
kkmr
pushed a commit
to kkmr/OpenSearch
that referenced
this pull request
Aug 28, 2023
…nsearch-project#9081) Add the following functions in Painless script score context: * termfreq * tf * totaltermfreq * sumtotaltermfreq Each of these maps to a Lucene value source. Signed-off-by: Louis Chu <clingzhi@amazon.com> Signed-off-by: Kiran Reddy <kkreddy@amazon.com>
kaushalmahi12
pushed a commit
to kaushalmahi12/OpenSearch
that referenced
this pull request
Sep 12, 2023
…nsearch-project#9081) Add the following functions in Painless script score context: * termfreq * tf * totaltermfreq * sumtotaltermfreq Each of these maps to a Lucene value source. Signed-off-by: Louis Chu <clingzhi@amazon.com> Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
brusic
pushed a commit
to brusic/OpenSearch
that referenced
this pull request
Sep 25, 2023
…nsearch-project#9081) Add the following functions in Painless script score context: * termfreq * tf * totaltermfreq * sumtotaltermfreq Each of these maps to a Lucene value source. Signed-off-by: Louis Chu <clingzhi@amazon.com> Signed-off-by: Ivan Brusic <ivan.brusic@flocksafety.com>
shiv0408
pushed a commit
to Gaurav614/OpenSearch
that referenced
this pull request
Apr 25, 2024
…nsearch-project#9081) Add the following functions in Painless script score context: * termfreq * tf * totaltermfreq * sumtotaltermfreq Each of these maps to a Lucene value source. Signed-off-by: Louis Chu <clingzhi@amazon.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Expose term frequency in Painless script score context.
Related Issues
Original issue - #7558
RFC - #8702
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.