Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved the logic to switch to exact search for restrictive filters search. #1059

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

navneet1v
Copy link
Collaborator

@navneet1v navneet1v commented Aug 23, 2023

Description

Improved the logic to switch to exact search for restrictive filters search.

This change includes:

  • adding 2 extra advanced K-NN settings on when to do exact search for users to tune.

This change doesn't include:

  • switching to exact search based on how many distance calculation needs to be done. Once this PR flows I will discuss more on the github issue to see how we want to implement it.

For understanding the details of the change please refer this issue: #1049

The integration tests are failing as the new backward incompatible changes are not available in snapshot. opensearch-project/OpenSearch#9081 (comment)

Issues Resolved

#1049

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…search.

This change includes:
* adding 2 extra advanced K-NN settings on when to do exact search for users to tune.

Signed-off-by: Navneet Verma <navneev@amazon.com>
@navneet1v navneet1v merged commit 4edc1bf into opensearch-project:main Aug 23, 2023
5 of 37 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 23, 2023
…search. (#1059)

This change includes:
* adding 2 extra advanced K-NN settings on when to do exact search for users to tune.

Signed-off-by: Navneet Verma <navneev@amazon.com>
(cherry picked from commit 4edc1bf)
@navneet1v navneet1v added the v2.10.0 Issues targeting release v2.10.0 label Aug 23, 2023
navneet1v added a commit that referenced this pull request Aug 23, 2023
…search. (#1059) (#1060)

This change includes:
* adding 2 extra advanced K-NN settings on when to do exact search for users to tune.

Signed-off-by: Navneet Verma <navneev@amazon.com>
(cherry picked from commit 4edc1bf)

Co-authored-by: Navneet Verma <navneev@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x enhancement Features Introduces a new unit of functionality that satisfies a requirement v2.10.0 Issues targeting release v2.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants