[BUG] org.opensearch.client.RestClientSingleHostIntegTests.testRequestResetAndAbort is flaky

[reta]

Description

The issue was caused by race between aborting the HTTP request and completing the resulting future. Added Phaser to predictably control the cancellation race.

Related Issues

Resolves #9034

Check List

• New functionality includes testing.
  • All tests pass
• New functionality has been documented.
  • New functionality has javadoc added
• Commits are signed per the DCO using --signoff
• Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[opensearch-trigger-bot]

Compatibility status:

> Task :checkCompatibility
Incompatible components: [https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/performance-analyzer.git]
Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git]

BUILD SUCCESSFUL in 33m 58s

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/22274/
• CommitID: 5716523
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[Poojita-Raj]

Gradle Check (Jenkins) Run Completed with:

* **RESULT:** FAILURE ❌

* **URL:** https://build.ci.opensearch.org/job/gradle-check/22274/

* **CommitID:** [5716523](https://github.com/opensearch-project/OpenSearch/commit/571652330302a39363a094940575fd55b5d6a4e2)
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure [a flaky test](https://github.com/opensearch-project/OpenSearch/blob/main/DEVELOPER_GUIDE.md#flaky-tests) unrelated to your change?

flaky: #9116

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/22281/
• CommitID: 5716523
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[kotwanikunal]

#9181
@reta Can you please rebase? The above test was already muted.

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/22291/
• CommitID: 5716523
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/22302/
• CommitID: 5716523
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: UNSTABLE ❕
• TEST FAILURES:

      1 org.opensearch.remotestore.SegmentReplicationUsingRemoteStoreIT.testDropPrimaryDuringReplication

• URL: https://build.ci.opensearch.org/job/gradle-check/22306/
• CommitID: 5716523
  Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

[codecov]

Codecov Report

Merging #9206 (5716523) into main (e1eade1) will increase coverage by 0.11%.
Report is 11 commits behind head on main.
The diff coverage is 86.66%.

@@             Coverage Diff              @@
##               main    #9206      +/-   ##
============================================
+ Coverage     71.06%   71.18%   +0.11%     
- Complexity    57328    57413      +85     
============================================
  Files          4766     4768       +2     
  Lines        270512   270540      +28     
  Branches      39557    39559       +2     
============================================
+ Hits         192229   192572     +343     
+ Misses        62115    61782     -333     
- Partials      16168    16186      +18     

Files Changed	Coverage Δ
...java/org/opensearch/index/engine/EngineConfig.java	96.05% <ø> (ø)
.../opensearch/telemetry/tracing/noop/NoopTracer.java	80.00% <50.00%> (-20.00%)	⬇️
...rg/opensearch/telemetry/tracing/WrappedTracer.java	83.33% <50.00%> (-16.67%)	⬇️
...rg/opensearch/telemetry/tracing/DefaultTracer.java	92.30% <85.71%> (-2.70%)	⬇️
.../org/opensearch/telemetry/tracing/SpanContext.java	100.00% <100.00%> (ø)
.../telemetry/tracing/runnable/TraceableRunnable.java	100.00% <100.00%> (ø)
.../java/org/opensearch/index/codec/CodecService.java	100.00% <100.00%> (ø)

... and 482 files with indirect coverage changes

[opensearch-trigger-bot]

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-9206-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d014c4d280108db78427f330c7ea1c677c22603e
# Push it to GitHub
git push --set-upstream origin backport/backport-9206-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-9206-to-2.x.

[reta]

UPD: No need to backport, 2.x still uses Apache HttpClient 4