Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix branch version. #1595

Merged
merged 1 commit into from
Jul 3, 2024
Merged

Conversation

AWSHurneyt
Copy link
Collaborator

Issue #, if available:

Description of changes:
PR #1593 accidentally bumped 2.15 branch to v2.16. Fixing that increment.

CheckList:

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
@AWSHurneyt AWSHurneyt changed the title Changed 2.15 branch back to v2.15 from v2.16. Fix branch version. Jul 3, 2024
Copy link
Member

@eirsep eirsep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you check if version variable in spi's build.grade comes from this variable and is not being hardcoded again?

@AWSHurneyt
Copy link
Collaborator Author

can you check if version variable in spi's build.grade comes from this variable and is not being hardcoded again?

It's not hard coded. The SPI build.gradle uses the opensearc_versionvariable
https://github.com/opensearch-project/alerting/blob/main/spi/build.gradle#L20

Which gets defined in the main build.gradle
https://github.com/opensearch-project/alerting/blob/main/build.gradle#L10

@eirsep eirsep merged commit b50c1fd into opensearch-project:2.15 Jul 3, 2024
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants