[Backport 2.7] Giving admin priority over backendrole filtering (#850) #860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
) * giving admin priority over backend role filtering Signed-off-by: Amit Galitzky <amgalitz@amazon.com> * fix security tests Signed-off-by: Amit Galitzky <amgalitz@amazon.com> * remove redundent line in test case Signed-off-by: Amit Galitzky <amgalitz@amazon.com> --------- Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
amitgalitz
force-pushed
the
backport-admin-2-7
branch
from
86c5547
to
2be0897
Compare
jackiehanyang
approved these changes
Apr 11, 2023
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## 2.7 #860 +/- ##
============================================
- Coverage 79.39% 79.34% -0.06%
+ Complexity 4315 4314 -1
============================================
Files 307 307
Lines 18144 18147 +3
Branches 1909 1909
============================================
- Hits 14406 14398 -8
- Misses 2819 2827 +8
- Partials 919 922 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
kaituo
approved these changes
Apr 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backporting #850 to 2.7
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.