Onboard jenkins prod docker images to github actions #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
peterzhuamazon
requested review from
andrross,
reta,
nknize and
sarthakaggarwal97
as code owners
reta
approved these changes
Nov 1, 2023
reta
reviewed
Nov 1, 2023
.github/workflows/check.yml
Outdated
|
|
||
| steps: | ||
| - uses: actions/checkout@v3 | ||
| - name: Set up JDK 11 |
There was a problem hiding this comment.
Do we need this step? Our CI image has all JDKs pre-installed
There was a problem hiding this comment.
Yes, but it is easier just to use this installation, than setting an env var here.
There was a problem hiding this comment.
Discussed offline: we should no alter our CI image since the goal is to use the same env
There was a problem hiding this comment.
Adding a matrix as well and will use -Druntime.java=
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 1, 2023
* Onboard jenkins prod docker images to github actions Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Add more Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Add more Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Add more Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Add more Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> --------- Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> (cherry picked from commit c85334e) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
reta
added a commit
that referenced
this pull request
Nov 1, 2023
) * Onboard jenkins prod docker images to github actions (#76) * Onboard jenkins prod docker images to github actions Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Add more Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Add more Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Add more Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Add more Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> --------- Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> (cherry picked from commit c85334e) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * remove jdk21 Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Explicitly set JAVA_HOME to JDK-11 for Gradle build Signed-off-by: Andriy Redko <andriy.redko@aiven.io> * Update OpenSearch core version to 2.12.0-SNAPSHOT Signed-off-by: Andriy Redko <andriy.redko@aiven.io> * Removed explicit -Druntime.java version specifier for Gradle check Signed-off-by: Andriy Redko <andriy.redko@aiven.io> --------- Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Andriy Redko <andriy.redko@aiven.io> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Peter Zhu <zhujiaxi@amazon.com> Co-authored-by: Andriy Redko <andriy.redko@aiven.io>
95 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Onboard jenkins prod docker images to github actions
Issues Resolved
#75
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.