Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Onboard jenkins prod docker images to github actions #76

Merged
merged 5 commits into from
Nov 1, 2023
Merged

Onboard jenkins prod docker images to github actions #76

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
abaade4
Onboard jenkins prod docker images to github actions
peterzhuamazon Nov 1, 2023
84ae542
Add more
peterzhuamazon Nov 1, 2023
4e705fc
Add more
peterzhuamazon Nov 1, 2023
027bc88
Add more
peterzhuamazon Nov 1, 2023
1686c1d
Add more
peterzhuamazon Nov 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 37 additions & 2 deletions .github/workflows/check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,47 @@ name: Gradle Check
on: [pull_request]

jobs:
precommit:
Get-CI-Image-Tag:
uses: opensearch-project/opensearch-build/.github/workflows/get-ci-image-tag.yml@main
with:
product: opensearch

precommit-linux:
needs: Get-CI-Image-Tag
if: github.repository == 'opensearch-project/custom-codecs'
runs-on: ubuntu-latest
container:
# using the same image which is used by opensearch-build team to build the OpenSearch Distribution
# this image tag is subject to change as more dependencies and updates will arrive over time
image: ${{ needs.Get-CI-Image-Tag.outputs.ci-image-version-linux }}
# need to switch to root so that github actions can install runner binary on container without permission issues.
options: --user root

steps:
- uses: actions/checkout@v3
- name: Set up JDK 11
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this step? Our CI image has all JDKs pre-installed

Copy link
Member Author

@peterzhuamazon peterzhuamazon Nov 1, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but it is easier just to use this installation, than setting an env var here.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed offline: we should no alter our CI image since the goal is to use the same env

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a matrix as well and will use -Druntime.java=

uses: actions/setup-java@v3
with:
java-version: 11
distribution: temurin
cache: gradle
- name: Run Gradle (check)
run: |
# https://github.com/opensearch-project/opensearch-build/issues/4191
chown -R opensearch:opensearch `pwd`
su opensearch -c "./gradlew check"
- name: Run Gradle (assemble)
run: |
# https://github.com/opensearch-project/opensearch-build/issues/4191
chown -R opensearch:opensearch `pwd`
su opensearch -c "./gradlew assemble"

precommit-windows-macos:
if: github.repository == 'opensearch-project/custom-codecs'
runs-on: ${{ matrix.os }}
strategy:
matrix:
os: [ubuntu-latest, windows-latest, macos-latest]
os: [windows-latest, macos-latest]
steps:
- uses: actions/checkout@v3
- name: Set up JDK 11
Expand Down
Loading