Add scroll bar when more layers added #254
Conversation
| .euiDroppable { | ||
| overflow-y: auto; | ||
| overflow-x: hidden; | ||
| max-height: $euiSizeL * 8; |
There was a problem hiding this comment.
What is the default value of this elastic ui variable $euiSizeL?
There was a problem hiding this comment.
Per euiSizeL is 24 px, so here max-height is 192 px. Per layer is 32 px height, maximum in screen displayed layers number is 6.
Signed-off-by: Junqiu Lei <junqiu@amazon.com>
junqiu-lei
force-pushed
the
scroll_layer
branch
from
e8831ff
to
3756a99
Compare
|
The unit test and e2e failed due to opensearch-project/OpenSearch-Dashboards@de89c52#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519R136, also found in other plugins, asked @zhongnansu for helping look into it |
|
Did you check moving layers still works? |
Yes, it works |
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #254 +/- ##
=======================================
Coverage 91.66% 91.66%
=======================================
Files 10 10
Lines 264 264
Branches 34 34
=======================================
Hits 242 242
Misses 16 16
Partials 6 6 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Junqiu Lei <junqiu@amazon.com> (cherry picked from commit f3d21b9)
Description
Add scroll bar when more layers added on panel, set a max height to the layer list panel. In screen displayed layers will be maximum to 6.
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.