Fix zoom level type error in custom layer #605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Junqiu Lei <junqiu@amazon.com>
junqiu-lei
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda and
martin-gaievski
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #605 +/- ##
==========================================
+ Coverage 41.36% 43.89% +2.53%
==========================================
Files 53 53
Lines 1789 1795 +6
Branches 330 331 +1
==========================================
+ Hits 740 788 +48
+ Misses 1019 968 -51
- Partials 30 39 +9 ☔ View full report in Codecov by Sentry. |
|
Cypress test passed on my local, the failure on the CI is unrelated to the PR. |
|
Can we add unit test? Please add screenshot / video on how you tested it. Thanks |
Sure |
Signed-off-by: Junqiu Lei <junqiu@amazon.com>
@VijayanB Unit tests and test video added. |
VijayanB
approved these changes
Apr 2, 2024
naveentatikonda
approved these changes
Apr 2, 2024
|
@junqiu-lei Are we not backporting this to 2.x ? |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 2, 2024
* Fix zoom level type error in custom layer Signed-off-by: Junqiu Lei <junqiu@amazon.com> (cherry picked from commit 4d21bf0)
We need backport 2.x, added tag at the same time |
junqiu-lei
added a commit
that referenced
this pull request
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix zoom level type error in custom layer.
Issues Resolved
Closes #604
Test Demo
Screen.Recording.2024-04-02.at.9.15.30.AM.mov
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.