Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reporting menu item #295

Merged
merged 1 commit into from
Feb 16, 2024
Merged

Conversation

gulderov
Copy link
Contributor

@gulderov gulderov commented Feb 15, 2024

Issues Resolved

Fix #294

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Danila Gulderov <danila@gulderov.me>
Copy link

codecov bot commented Feb 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0441f07) 74.47% compared to head (267128d) 74.47%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #295   +/-   ##
=======================================
  Coverage   74.47%   74.47%           
=======================================
  Files          30       30           
  Lines        1904     1904           
  Branches      410      410           
=======================================
  Hits         1418     1418           
  Misses        483      483           
  Partials        3        3           
Flag Coverage Δ
dashboards-report 74.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ashwin-pc
Copy link
Member

This is cause due to #118. This bar is likely to change again and the current solution is too flakey to keep buiding on top of it. Else every release this will be a miss

@rupal-bq rupal-bq merged commit 58d52f7 into opensearch-project:main Feb 16, 2024
10 of 13 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 16, 2024
Signed-off-by: Danila Gulderov <danila@gulderov.me>
(cherry picked from commit 58d52f7)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
rupal-bq pushed a commit that referenced this pull request Feb 16, 2024
(cherry picked from commit 58d52f7)

Signed-off-by: Danila Gulderov <danila@gulderov.me>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 16, 2024
Signed-off-by: Danila Gulderov <danila@gulderov.me>
(cherry picked from commit 58d52f7)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
rupal-bq pushed a commit that referenced this pull request Feb 16, 2024
(cherry picked from commit 58d52f7)

Signed-off-by: Danila Gulderov <danila@gulderov.me>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
gulderov added a commit to gulderov/dashboards-reporting that referenced this pull request Mar 5, 2024
…e-define) (opensearch-project#295)

Signed-off-by: Danila Gulderov <danila@gulderov.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Reporting is missing from the navigation menu
4 participants