[Backport 2.x] Added a new parse util method to avoid repetition / refactored code with new method #728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
…ith new method (#721) * Add user mapping to Workflow State index (#705) * Add user mapping to Workflow State index Signed-off-by: Daniel Widdis <widdis@gmail.com> * Increment schema version Signed-off-by: Daniel Widdis <widdis@gmail.com> --------- Signed-off-by: Daniel Widdis <widdis@gmail.com> Signed-off-by: martinpkr <devilmarti@abv.bg> * Added a new parse util method to avoid repetition / refactored code with new method Signed-off-by: martinpkr <devilmarti@abv.bg> * refactored method name and added unit test Signed-off-by: martinpkr <devilmarti@abv.bg> * made method use generics + added test Signed-off-by: martinpkr <devilmarti@abv.bg> * fixed javadoc Signed-off-by: martinpkr <devilmarti@abv.bg> * Added workflow step for ReIndex Step (#718) * Initial commit for reindex workflow step with extra params Signed-off-by: owaiskazi19 <owaiskazi19@gmail.com> * Addressed PR comments Signed-off-by: owaiskazi19 <owaiskazi19@gmail.com> * Changed request per second to Float Signed-off-by: owaiskazi19 <owaiskazi19@gmail.com> * Addressed string array for source indices and removed state index entry Signed-off-by: owaiskazi19 <owaiskazi19@gmail.com> * Minor comments Signed-off-by: owaiskazi19 <owaiskazi19@gmail.com> --------- Signed-off-by: owaiskazi19 <owaiskazi19@gmail.com> Signed-off-by: martinpkr <devilmarti@abv.bg> * Incorporating parseIfExist method into ReindexStep class Signed-off-by: martinpkr <devilmarti@abv.bg> * Add param to delete workflow API to clear status even if resources exist (#719) Signed-off-by: Daniel Widdis <widdis@gmail.com> Signed-off-by: martinpkr <devilmarti@abv.bg> * refactored method to use parseBoolean and parseFloat methods Signed-off-by: martinpkr <devilmarti@abv.bg> * Adding a missing param in javaDoc Signed-off-by: martinpkr <devilmarti@abv.bg> * Added workflow step for ReIndex Step (#718) * Initial commit for reindex workflow step with extra params Signed-off-by: owaiskazi19 <owaiskazi19@gmail.com> * Addressed PR comments Signed-off-by: owaiskazi19 <owaiskazi19@gmail.com> * Changed request per second to Float Signed-off-by: owaiskazi19 <owaiskazi19@gmail.com> * Addressed string array for source indices and removed state index entry Signed-off-by: owaiskazi19 <owaiskazi19@gmail.com> * Minor comments Signed-off-by: owaiskazi19 <owaiskazi19@gmail.com> --------- Signed-off-by: owaiskazi19 <owaiskazi19@gmail.com> Signed-off-by: martinpkr <devilmarti@abv.bg> * Add param to delete workflow API to clear status even if resources exist (#719) Signed-off-by: Daniel Widdis <widdis@gmail.com> Signed-off-by: martinpkr <devilmarti@abv.bg> * Added a chagelog entry Signed-off-by: martinpkr <devilmarti@abv.bg> * fixed failing spotless check Signed-off-by: martinpkr <devilmarti@abv.bg> * Added workflow step for ReIndex Step (#718) * Initial commit for reindex workflow step with extra params Signed-off-by: owaiskazi19 <owaiskazi19@gmail.com> * Addressed PR comments Signed-off-by: owaiskazi19 <owaiskazi19@gmail.com> * Changed request per second to Float Signed-off-by: owaiskazi19 <owaiskazi19@gmail.com> * Addressed string array for source indices and removed state index entry Signed-off-by: owaiskazi19 <owaiskazi19@gmail.com> * Minor comments Signed-off-by: owaiskazi19 <owaiskazi19@gmail.com> --------- Signed-off-by: owaiskazi19 <owaiskazi19@gmail.com> Signed-off-by: martinpkr <devilmarti@abv.bg> * removed unnecessary changelog info Signed-off-by: martinpkr <devilmarti@abv.bg> --------- Signed-off-by: Daniel Widdis <widdis@gmail.com> Signed-off-by: martinpkr <devilmarti@abv.bg> Signed-off-by: owaiskazi19 <owaiskazi19@gmail.com> Co-authored-by: Daniel Widdis <widdis@gmail.com> Co-authored-by: Owais Kazi <owaiskazi19@gmail.com> (cherry picked from commit 13b32f1) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
requested review from
dbwiddis,
owaiskazi19,
joshpalis,
ohltyler,
amitgalitz and
jackiehanyang
as code owners
dbwiddis
approved these changes
Jun 3, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #728 +/- ##
============================================
+ Coverage 74.33% 74.41% +0.07%
- Complexity 742 744 +2
============================================
Files 84 84
Lines 3807 3811 +4
Branches 332 330 -2
============================================
+ Hits 2830 2836 +6
Misses 823 823
+ Partials 154 152 -2 ☔ View full report in Codecov by Sentry. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 13b32f1 from #721.