adding MDS support for ISM Pages: Indices, Aliases, DataStreams, Templates & Component Templates

[RamakrishnaChilaka]

Description

This change adds multi data source selector (described in opensearch-project/OpenSearch-Dashboards#6035). This change adds MDS support to Indices, Aliases, Data streams, Templates & Component template pages. There will be a follow-up PR raised for the remaining pages.

Issues Resolved

#982 This issue will be solved partially through this PR.

Check List

• [✅] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[SuZhou-Joe]

Looks much better and thanks for the quick update.

Concerns left:

1. Is it doable that we compute dataSourceLabel by using dataSourceList and dataSourceId?
2. Can we keep one convention to pass dataSourceId across ISM?

[RamakrishnaChilaka]

Concerns left:

Is it doable that we compute dataSourceLabel by using dataSourceList and dataSourceId?

I will confirm on this by syncing up with opensearch-core team once by the end of this week, as new features are being rolled out in the data source picker this week.

Can we keep one convention to pass dataSourceId across ISM?

I will work on this and try to come up with a convention for passing data source id across ISM..

[RamakrishnaChilaka]

@SuZhou-Joe, if we use data source id to compute data source label, it will involve a database read call and ISM plugin needs to be aware of the schema of the index where these data source details are being stored and if this schema changes our code might break. Therefore, in my opinion, we should avoid computing this in the plugin if possible and abstract this functionality away to DataSourceMenu component in the core. I believe with the current implementation of DataSourceMenu in the core's main branch, we can avoid storing DataSourceLabel in our plugin's state. Pasting the GitHub issue where this is being discussed opensearch-project/OpenSearch-Dashboards#6035 (comment).

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.43%. Comparing base (d516380) to head (bf5558d).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1006      +/-   ##
==========================================
+ Coverage   63.37%   63.43%   +0.06%     
==========================================
  Files         341      344       +3     
  Lines       11554    11668     +114     
  Branches     2243     2260      +17     
==========================================
+ Hits         7322     7402      +80     
- Misses       3658     3689      +31     
- Partials      574      577       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[opensearch-trigger-bot]

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/index-management-dashboards-plugin/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/index-management-dashboards-plugin/backport-2.x
# Create a new branch
git switch --create backport/backport-1006-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b151b851ef06234196208bc4505737aba375e307
# Push it to GitHub
git push --set-upstream origin backport/backport-1006-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/index-management-dashboards-plugin/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-1006-to-2.x.