fixed alias3 contains error #918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kohinoor98 <kohinoorchatterjee1998@gmail.com>
kohinoor98
requested review from
amsiglan,
AWSHurneyt,
bowenlan-amzn,
getsaurabh02,
praveensameneni,
xluo-aws,
gaobinlong,
Hailong-am,
SuZhou-Joe,
lezzago,
sbcd90 and
eirsep
as code owners
Codecov Report
@@ Coverage Diff @@
## main #918 +/- ##
=======================================
Coverage 63.36% 63.36%
=======================================
Files 341 341
Lines 11553 11553
Branches 2243 2243
=======================================
Hits 7321 7321
Misses 3658 3658
Partials 574 574 |
|
@kohinoor98 the policies spec test is passing, but looks like an alias spec test started failing. Could you look into whether that's related to your changes? |
|
Hi @AWSHurneyt, The test case this PR is failing is flaky as tagged in #910 and the proposed solution is also created for it #920. Please guide on next steps. Thanks, |
2 tasks
AWSHurneyt
approved these changes
Nov 8, 2023
Ah thanks for that context. Approved. |
bowenlan-amzn
approved these changes
Nov 8, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 8, 2023
Signed-off-by: kohinoor98 <kohinoorchatterjee1998@gmail.com> Co-authored-by: bowenlan-amzn <bowenlan23@gmail.com> (cherry picked from commit 461f563) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
bowenlan-amzn
added a commit
that referenced
this pull request
Nov 8, 2023
(cherry picked from commit 461f563) Signed-off-by: kohinoor98 <kohinoorchatterjee1998@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: bowenlan-amzn <bowenlan23@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
alias3 gets removed as per instructions from
sample_policy_alias_action.json. In the final contains verification we do not need to check for alias3.Issues Resolved
#911
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.