snapshots_spec.js tests updated #933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kohinoor98 <kohinoorchatterjee1998@gmail.com>
kohinoor98
requested review from
amsiglan,
AWSHurneyt,
bowenlan-amzn,
getsaurabh02,
praveensameneni,
xluo-aws,
gaobinlong,
Hailong-am,
SuZhou-Joe,
lezzago,
sbcd90 and
eirsep
as code owners
Signed-off-by: kohinoor98 <kohinoorchatterjee1998@gmail.com>
cypress/integration/plugins/index-management-dashboards-plugin/snapshots_spec.js
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #933 +/- ##
========================================
Coverage 63.37% 63.37%
========================================
Files 341 341
Lines 11554 11554
Branches 2243 2112 -131
========================================
Hits 7322 7322
Misses 3658 3658
Partials 574 574 ☔ View full report in Codecov by Sentry. |
Signed-off-by: kohinoor98 <kohinoorchatterjee1998@gmail.com>
Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>
bowenlan-amzn
approved these changes
Jan 10, 2024
SuZhou-Joe
approved these changes
Jan 16, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 18, 2024
Co-authored-by: bowenlan-amzn <bowenlan23@gmail.com> (cherry picked from commit 3c2a9a4) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
bowenlan-amzn
added a commit
to bowenlan-amzn/index-management-dashboards-plugin
that referenced
this pull request
Jan 18, 2024
Co-authored-by: bowenlan-amzn <bowenlan23@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added waits and made the flaky test more accurate by close observation and multiple runs.
Issues Resolved
#925
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.