Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rollups/transform: wait for page to render #993

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

r1walz
Copy link
Contributor

@r1walz r1walz commented Feb 16, 2024

Description

Adding intercepts and wait time to mitigate flaky tests.

Issues Resolved

#968

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

vikasvb90
vikasvb90 previously approved these changes Feb 16, 2024
Copy link

codecov bot commented Feb 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (550c6e4) 63.37% compared to head (df0afeb) 63.37%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #993   +/-   ##
=======================================
  Coverage   63.37%   63.37%           
=======================================
  Files         341      341           
  Lines       11554    11554           
  Branches     2112     2112           
=======================================
  Hits         7322     7322           
  Misses       3658     3658           
  Partials      574      574           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

bowenlan-amzn
bowenlan-amzn previously approved these changes Feb 16, 2024
Signed-off-by: Rohit Ashiwal <rashiwal@amazon.com>
@r1walz r1walz dismissed stale reviews from bowenlan-amzn and vikasvb90 via df0afeb February 16, 2024 18:01
@r1walz r1walz changed the title ism-dp/transform: wait for page to render rollups/transform: wait for page to render Feb 16, 2024
@r1walz r1walz added the v2.12.0 label Feb 16, 2024
@r1walz r1walz merged commit 0dcfd43 into opensearch-project:main Mar 13, 2024
12 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 13, 2024
Signed-off-by: Rohit Ashiwal <rashiwal@amazon.com>
(cherry picked from commit 0dcfd43)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 13, 2024
Signed-off-by: Rohit Ashiwal <rashiwal@amazon.com>
(cherry picked from commit 0dcfd43)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@r1walz r1walz deleted the ism-transform branch March 13, 2024 09:17
r1walz pushed a commit that referenced this pull request Mar 19, 2024
Signed-off-by: Rohit Ashiwal <rashiwal@amazon.com>
(cherry picked from commit 0dcfd43)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants