-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rollups/transform: wait for page to render #993
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r1walz
requested review from
amsiglan,
AWSHurneyt,
bowenlan-amzn,
getsaurabh02,
praveensameneni,
xluo-aws,
gaobinlong,
Hailong-am,
SuZhou-Joe,
lezzago,
sbcd90,
eirsep and
vikasvb90
as code owners
February 16, 2024 17:15
vikasvb90
previously approved these changes
Feb 16, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #993 +/- ##
=======================================
Coverage 63.37% 63.37%
=======================================
Files 341 341
Lines 11554 11554
Branches 2112 2112
=======================================
Hits 7322 7322
Misses 3658 3658
Partials 574 574 ☔ View full report in Codecov by Sentry. |
bowenlan-amzn
previously approved these changes
Feb 16, 2024
Signed-off-by: Rohit Ashiwal <rashiwal@amazon.com>
r1walz
force-pushed
the
ism-transform
branch
from
February 16, 2024 18:01
0bc31f6
to
df0afeb
Compare
r1walz
changed the title
ism-dp/transform: wait for page to render
rollups/transform: wait for page to render
Feb 16, 2024
1 task
cypress/integration/plugins/index-management-dashboards-plugin/rollups_spec.js
Show resolved
Hide resolved
vikasvb90
approved these changes
Mar 13, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 13, 2024
Signed-off-by: Rohit Ashiwal <rashiwal@amazon.com> (cherry picked from commit 0dcfd43) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 13, 2024
Signed-off-by: Rohit Ashiwal <rashiwal@amazon.com> (cherry picked from commit 0dcfd43) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
r1walz
pushed a commit
that referenced
this pull request
Mar 19, 2024
Signed-off-by: Rohit Ashiwal <rashiwal@amazon.com> (cherry picked from commit 0dcfd43) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding intercepts and wait time to mitigate flaky tests.
Issues Resolved
#968
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.