Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish MD5 and SHA1 signatures. #71

Merged
merged 2 commits into from
Oct 7, 2021

Conversation

dblock
Copy link
Member

@dblock dblock commented Oct 6, 2021

Signed-off-by: dblock dblock@dblock.org

Description

Similar to opensearch-project/common-utils#80 and opensearch-project/common-utils#79.

  1. Publish SHA1 and MD5 signatures with the JAR artifact. A workaround for Attempting to publish to Sonatype staging fails to produce checksums GradleUp/shadow#718.
  2. Remove signing and publishing workflow that no longer runs because the maven repo target had been removed earlier.
  3. Move in the custom build script into the repo.
  4. Removes job-scheduler from publication, only publishes spi, which causes [BUG] Invalid POM: /org/opensearch/opensearch-job-scheduler/1.1.0.0/opensearch-job-scheduler-1.1.0.0.pom #70.

Issues Resolved

Closes #69 and #70.

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

lezzago
lezzago previously approved these changes Oct 6, 2021
Signed-off-by: dblock <dblock@dblock.org>
Signed-off-by: dblock <dblock@dblock.org>
ant.checksum algorithm: 'sha-512', file: it.archivePath, fileext: '.sha512'
}
}

publishing {
Copy link
Member

@saratvemulapalli saratvemulapalli Oct 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Side note: We have to get rid of AWS org and change it to OpenSearch, opensearch-project.

              developers {
                developer {
                  id = "amazonwebservices"
                  organization = "Amazon Web Services"
                  organizationUrl = "https://aws.amazon.com"
                }
              }

Ref: https://github.com/opensearch-project/job-scheduler/pull/71/files#diff-ddfd6f002852c4395d6a0303ccf59041623cc8608a8a4acb4af5f2e8137ebc03R152

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll leave it to @lezzago

@dblock dblock merged commit 0f368a7 into opensearch-project:main Oct 7, 2021
@dblock dblock deleted the publish-signatures branch October 7, 2021 00:01
dblock added a commit to opensearch-project/opensearch-build that referenced this pull request Oct 7, 2021
* Removed scripts that were added into their respective repos.

See:

opensearch-project/common-utils#79
opensearch-project/common-utils#80
opensearch-project/job-scheduler#71
opensearch-project/job-scheduler#72

Signed-off-by: dblock <dblock@dblock.org>

* Removed PA and PA RCA from Maven publication.

Signed-off-by: dblock <dblock@dblock.org>

* Removed alerting that was moved to its repo.

opensearch-project/alerting#196
opensearch-project/alerting#197

Signed-off-by: dblock <dblock@dblock.org>
qreshi added a commit that referenced this pull request Nov 4, 2021
* Enabled automated license header checks (#36)

1. Re-enabled the 'licenseHeaders' check in the build.gradle file.
2. Added an IntelliJ copyright profile to auto-generate the SPDX license header.

Signed-off-by: Ketan Verma <ketan9495@gmail.com>

* Release 1.0.0.0 (#40)

Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>

* Bumping job-scheduler to build with OpenSearch(main) 1.1.0 (#44)

* Bumping job-scheduler to build with OpenSearch(main) 1.1.0

Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>

* Updating docs link to our documentation website.

Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>

* Using 1.1 snapshot version for OpenSearch (#48)

Signed-off-by: Vacha <vachshah@amazon.com>

* Use standard snapshot build settings and OpenSearch 1.x. (#49)

Signed-off-by: dblock <dblock@amazon.com>

* Add `Getting Started` to Readme  (#50)

* added Getting Started section

* Adds a delay parameter to the job scheduler (#61)

* Adds delay parameter to job scheduler

* Adds tests for job scheduler delay parameter

* Changes test and build workflow to 1.1 and corrects links

Signed-off-by: Clay Downs <downsrob@amazon.com>

* Updates job scheduler version to 1.2 (#68)

* Updates job scheduler version to 1.2 and uses Maven for 1.2 dependencies

Signed-off-by: Clay Downs <downsrob@amazon.com>

* Publish MD5 and SHA1 signatures. (#71)

* Publish MD5 and SHA1 signatures.

Signed-off-by: dblock <dblock@dblock.org>

* Also publish 256 and 512 checksums.

Signed-off-by: dblock <dblock@dblock.org>

* Fixes possible negative jitter (#78)

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

Co-authored-by: Ketan Verma <ketanv3@users.noreply.github.com>
Co-authored-by: Bowen Lan <62091230+bowenlan-amzn@users.noreply.github.com>
Co-authored-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
Co-authored-by: Vacha <vachshah@amazon.com>
Co-authored-by: Daniel Doubrovkine (dB.) <dblock@dblock.org>
Co-authored-by: Sriram <59816283+skkosuri-amzn@users.noreply.github.com>
Co-authored-by: Clay Downs <89109232+downsrob@users.noreply.github.com>
Co-authored-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>
wuychn pushed a commit to ochprince/job-scheduler that referenced this pull request Mar 16, 2023
* Publish MD5 and SHA1 signatures.

Signed-off-by: dblock <dblock@dblock.org>

* Also publish 256 and 512 checksums.

Signed-off-by: dblock <dblock@dblock.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] publish to maven is not publishing sha1 and md5 checksums
3 participants