Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds integration test for invalid method parameters #1782

Merged

Conversation

shatejas
Copy link
Contributor

@shatejas shatejas commented Jul 1, 2024

Description

Adds invalid parameter integration test

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Tejas Shah <shatejas@amazon.com>
Copy link
Member

@ryanbogan ryanbogan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@junqiu-lei junqiu-lei merged commit e88e649 into opensearch-project:feature/ef-search Jul 1, 2024
46 of 52 checks passed
shatejas added a commit to shatejas/k-NN that referenced this pull request Jul 3, 2024
Adds integration test for invalid method parameters (opensearch-project#1782)

Signed-off-by: Tejas Shah <shatejas@amazon.com>
shatejas added a commit to shatejas/k-NN that referenced this pull request Jul 3, 2024
Adds integration test for invalid method parameters (opensearch-project#1782)

Signed-off-by: Tejas Shah <shatejas@amazon.com>
shatejas added a commit to shatejas/k-NN that referenced this pull request Jul 3, 2024
Adds integration test for invalid method parameters (opensearch-project#1782)

Signed-off-by: Tejas Shah <shatejas@amazon.com>
shatejas added a commit to shatejas/k-NN that referenced this pull request Jul 15, 2024
Adds integration test for invalid method parameters (opensearch-project#1782)

Signed-off-by: Tejas Shah <shatejas@amazon.com>
shatejas added a commit to shatejas/k-NN that referenced this pull request Jul 16, 2024
Adds integration test for invalid method parameters (opensearch-project#1782)

Signed-off-by: Tejas Shah <shatejas@amazon.com>
navneet1v pushed a commit that referenced this pull request Jul 16, 2024
Adds integration test for invalid method parameters (#1782)

Signed-off-by: Tejas Shah <shatejas@amazon.com>
shatejas added a commit to shatejas/k-NN that referenced this pull request Jul 16, 2024
…) (opensearch-project#1792)

Adds integration test for invalid method parameters (opensearch-project#1782)

Signed-off-by: Tejas Shah <shatejas@amazon.com>
(cherry picked from commit b422466)
jmazanec15 pushed a commit that referenced this pull request Jul 17, 2024
Adds integration test for invalid method parameters (#1782)

Signed-off-by: Tejas Shah <shatejas@amazon.com>
(cherry picked from commit b422466)

Signed-off-by: Tejas Shah <shatejas@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants