-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds integration test for invalid method parameters #1782
Merged
junqiu-lei
merged 1 commit into
opensearch-project:feature/ef-search
from
shatejas:feature/ef-search
Jul 1, 2024
Merged
Adds integration test for invalid method parameters #1782
junqiu-lei
merged 1 commit into
opensearch-project:feature/ef-search
from
shatejas:feature/ef-search
Jul 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanbogan
reviewed
Jul 1, 2024
Signed-off-by: Tejas Shah <shatejas@amazon.com>
2e1dc89
to
8573aca
Compare
ryanbogan
approved these changes
Jul 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
junqiu-lei
approved these changes
Jul 1, 2024
e88e649
into
opensearch-project:feature/ef-search
46 of 52 checks passed
shatejas
added a commit
to shatejas/k-NN
that referenced
this pull request
Jul 3, 2024
Adds integration test for invalid method parameters (opensearch-project#1782) Signed-off-by: Tejas Shah <shatejas@amazon.com>
5 tasks
shatejas
added a commit
to shatejas/k-NN
that referenced
this pull request
Jul 3, 2024
Adds integration test for invalid method parameters (opensearch-project#1782) Signed-off-by: Tejas Shah <shatejas@amazon.com>
shatejas
added a commit
to shatejas/k-NN
that referenced
this pull request
Jul 3, 2024
Adds integration test for invalid method parameters (opensearch-project#1782) Signed-off-by: Tejas Shah <shatejas@amazon.com>
shatejas
added a commit
to shatejas/k-NN
that referenced
this pull request
Jul 15, 2024
Adds integration test for invalid method parameters (opensearch-project#1782) Signed-off-by: Tejas Shah <shatejas@amazon.com>
shatejas
added a commit
to shatejas/k-NN
that referenced
this pull request
Jul 16, 2024
Adds integration test for invalid method parameters (opensearch-project#1782) Signed-off-by: Tejas Shah <shatejas@amazon.com>
navneet1v
pushed a commit
that referenced
this pull request
Jul 16, 2024
shatejas
added a commit
to shatejas/k-NN
that referenced
this pull request
Jul 16, 2024
…) (opensearch-project#1792) Adds integration test for invalid method parameters (opensearch-project#1782) Signed-off-by: Tejas Shah <shatejas@amazon.com> (cherry picked from commit b422466)
5 tasks
jmazanec15
pushed a commit
that referenced
this pull request
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds invalid parameter integration test
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.