-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature/ef-search -> main] Adds Nprobe as a query parameter in knn query #1792
Conversation
82e95d8
to
b857823
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How is check handled to see if mapping uses IVF?
Happens in doToQuery(). It will throw an exception if there there is no context found |
If I understand correctly, these changes are already in the feature branch? |
Thats correct. I have linked the original Prs in the description |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Adds integration test for invalid method parameters (opensearch-project#1782) Signed-off-by: Tejas Shah <shatejas@amazon.com>
Signed-off-by: Tejas Shah <shatejas@amazon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks!
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-1792-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b4224661f3ad1a01a4fdd77e835af08ce2f0aa48
# Push it to GitHub
git push --set-upstream origin backport/backport-1792-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
…) (opensearch-project#1792) Adds integration test for invalid method parameters (opensearch-project#1782) Signed-off-by: Tejas Shah <shatejas@amazon.com> (cherry picked from commit b422466)
Adds integration test for invalid method parameters (#1782)
Description
Adds nprobes as a query parameter
This is cherry-picked from feature branch to main. Original PRs
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.