Removed JDK 11 and 17 version from CI runs #1921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
navneet1v
requested review from
heemin32,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
martin-gaievski,
ryanbogan and
luyuncheng
as code owners
Signed-off-by: Navneet Verma <navneev@amazon.com>
navneet1v
added
the
Maintenance
jmazanec15
approved these changes
Aug 1, 2024
vamshin
approved these changes
Aug 1, 2024
ryanbogan
approved these changes
Aug 1, 2024
|
@navneet1v shall we backport or no? Maybe we can leave other versions for BWC, but for CI/sec for 2.x I think jdk 21 is fine |
No we should not backport. Check this comment from @reta on neural search PR: opensearch-project/neural-search#838 (comment) |
|
Correct, JDK-21 baseline is only for 3.x line (aka |
Vikasht34
pushed a commit
to Vikasht34/k-NN
that referenced
this pull request
Aug 2, 2024
Signed-off-by: Navneet Verma <navneev@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed JDK 11 and 17 version from CI runs as main branch is moved to higher versions of JDK. I didn't make changes in the target and source compatibility because there is some other issues I am seeing for micro-benchmarks module. Will try to resolve it and then raise another PR for the same.
Related Issues
Ref: #1729
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.