Add dashboards rpm assemble support in opensearch-build repo

[peterzhuamazon]

Description

Add dashboards rpm assemble support in opensearch-build repo

Issues Resolved

#1545

Check List

• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[peterzhuamazon]

@spotrh could you help check the dashboards spec file again.
Thanks.

[codecov-commenter]

Codecov Report

Merging #1852 (3832b34) into main (092ffbe) will decrease coverage by 0.13%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #1852      +/-   ##
============================================
- Coverage     94.53%   94.40%   -0.14%     
  Complexity       19       19              
============================================
  Files           178      178              
  Lines          3625     3627       +2     
  Branches         27       27              
============================================
- Hits           3427     3424       -3     
- Misses          194      199       +5     
  Partials          4        4              

Impacted Files	Coverage Δ
src/assemble_workflow/bundle_rpm.py	84.90% <100.00%> (+0.59%)	⬆️
src/system/temporary_directory.py	83.87% <0.00%> (-12.91%)	⬇️
src/system/os.py	93.75% <0.00%> (-6.25%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 092ffbe...3832b34. Read the comment docs.

[tianleh]

Do you plan to fix the "missing starting space in comment"?

[peterzhuamazon]

Do you plan to fix the "missing starting space in comment"?

That is straight up copy directly from OpenSearch core and it is expected.

[dblock]

This looks hacky, why is any of this necessary? Why is it undoing something done in extract?

[peterzhuamazon]

This was in for the opensearch only change.
The reason being there is a hardcoded source /etc/sysconfig/opensearch line specifically in rpm version of core.
This caused the failure during installing of plugin zips.

In extract block we comment out the line and back up the original file.
Here we just move the backup back.

The change for dashboards is just to check if the file exist, if not then ignore this step.

Thanks.

[dblock]

Why isn't that line removed in the OpenSearch repo in the first place, why is this happening here?

I'll let it slide, but this is a hack on top of a hack.

[peterzhuamazon]

Improvement issue: #1864

[dblock]

Do you plan to fix the "missing starting space in comment"?

That is straight up copy directly from OpenSearch core and it is expected.

Why not fix it everywhere so that the YML look cleaner? Can be another PR.

Why are we copy-pasting an entire file? Doesn't this duplicate the original source of the documentation for it?

[spotrh]

Looks good to me without the /tmp permission item in the scriptlet.

[peterzhuamazon]

Do you plan to fix the "missing starting space in comment"?

That is straight up copy directly from OpenSearch core and it is expected.

Why not fix it everywhere so that the YML look cleaner? Can be another PR.

Why are we copy-pasting an entire file? Doesn't this duplicate the original source of the documentation for it?

OpenSearch core has an empty file of opensearch_dashboards.yml.
As for bundle with plugins we are using the one in config folder of this repo.
I just copy paste the comments here so if this change is not seems to be necessary, I can revert.

This just seems like a good way for user to have a template instead of finding the settings themselves.

[peterzhuamazon]

Looks good to me without the /tmp permission item in the scriptlet.

Thanks @spotrh I have removed the /tmp line now :)