Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable integration test failure notification via GitHub issues #3395

Merged
merged 2 commits into from
Apr 14, 2023

Conversation

gaiksaya
Copy link
Member

@gaiksaya gaiksaya commented Apr 14, 2023

Description

Enable notification for failed integration tests for opensearch-plugins. This will create GitHub issues for example: opensearch-project/k-NN#860

To-Do: Create integ-test-failure label across all opensearch plugins repos once this PR is approved.

Issues Resolved

closes #3383

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov-commenter
Copy link

codecov-commenter commented Apr 14, 2023

Codecov Report

Merging #3395 (4ffb221) into main (d626dfe) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main    #3395   +/-   ##
=======================================
  Coverage   91.74%   91.74%           
=======================================
  Files         172      172           
  Lines        4991     4991           
=======================================
  Hits         4579     4579           
  Misses        412      412           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

…enSearch plugins

Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
repoUrl: buildManifestObj.getRepo("${local_component}"),
issueTitle: "Integration Test failed for component ${local_component}: ${version}",
issueBody: issueBodyMessage,
label: "autocut,v${version},test-failure"
Copy link
Member

@bbarani bbarani Apr 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to be more specific with label here? i.e integ-test-failure instead of test-failure? We will be creating GitHub issues based on other test failures (BWC, performance test) soon so I think it would be better to add a specific label along with test-failure? What do you think?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure let me edit it.

Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
@gaiksaya
Copy link
Member Author

Labels have been created for opensearch-plugins

@gaiksaya gaiksaya merged commit 7c61e00 into opensearch-project:main Apr 14, 2023
@gaiksaya gaiksaya deleted the notification branch April 14, 2023 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notify test failures via GitHub issues
5 participants