Make sure docker is only checked on non-windows gradle check #3817
Conversation
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
peterzhuamazon
added
bug
peterzhuamazon
requested review from
dblock,
bbarani,
gaiksaya,
rishabh6788,
zelinh,
jordarlu,
prudhvigodithi,
Divyaasm and
tianleh
as code owners
Codecov Report
@@ Coverage Diff @@
## main #3817 +/- ##
==========================================
+ Coverage 91.54% 91.63% +0.08%
==========================================
Files 182 182
Lines 5420 5441 +21
==========================================
+ Hits 4962 4986 +24
+ Misses 458 455 -3 |
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
| else { | ||
| currentBuild.description = """runner: ${agent_name}<br><a href="${pr_url}">PR #${pr_number}</a>: ${pr_title}""" | ||
| } | ||
| if ( ! params.AGENT_LABEL.toLowerCase().contains('windows')) { |
There was a problem hiding this comment.
Question: What happens when the platform is windows?
There was a problem hiding this comment.
As of now windows does not have docker equipped.
However, I have recently add some new development in opensearch-project/opensearch-ci#281 so this PR might not need any changes anymore.
| if (!env.BUILD_CAUSE.contains('Started by user') && !env.BUILD_CAUSE.contains('Started by timer')) { | ||
| def pr_url = "${pr_to_clone_url}".replace(".git", "/pull/${pr_number}") | ||
| println("Triggered by GitHub: ${pr_to_clone_url}") | ||
| if ("$pr_number" == "Null") { |
There was a problem hiding this comment.
Didn't understand this case?
Can a PR not have a PR number or is this some other trigger?
There was a problem hiding this comment.
This is just changed due to spacing, the old itself is not changed for months.
It literally just to determine whether if this is triggered by PR then assign number of that PR in description, else dont.
|
We can close this now as I have new solutions since we have implemented Windows containers now. |
Description
Make sure docker is only checked on non-windows gradle check
Issues Resolved
#3816
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.