Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip flaky test and update document #92

Merged
merged 1 commit into from Feb 9, 2022

Conversation

Flyingliuhub
Copy link
Member

Signed-off-by: Tao Liu liutaoaz@amazon.com

Description

This PR is skipping one flaky test, and update the CONTRIBUTING.md.

Issues Resolved

resolves #90

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Tests

According to the Cypress: cypress-io/cypress#3092

Cypress considers a pending test to be any of the following:

it.skip(), context.skip, etc
it('some test') (no callback)
  dashboard filtering
    ✓ Buffer test for importing test environment data (25069ms)
    Adding and removing filters from a dashboard
      adding a filter that excludes all data
        ✓ Nonpinned filter: filters on pie charts (25448ms)
        ✓ Nonpinned filter: area, bar and heatmap charts filtered (147ms)
        ✓ Nonpinned filter: data tables are filtered
        ✓ Nonpinned filter: goal and guages are filtered (56ms)
        ✓ Nonpinned filter: tsvb time series shows no data message
        ✓ Nonpinned filter: metric value shows no data
        ✓ Nonpinned filter: tag cloud values are filtered
        ✓ Nonpinned filter: tsvb metric is filtered
        ✓ Nonpinned filter: tsvb top n is filtered (55ms)
        ✓ Nonpinned filter: saved search is filtered
        ✓ Nonpinned filter: vega is filtered (165ms)
      using a pinned filter that excludes all data
        ✓ Pinned filter: filters on pie charts (2623ms)
        ✓ Pinned filter: area, bar and heatmap charts filtered (172ms)
        ✓ Pinned filter: data tables are filtered
        ✓ Pinned filter: goal and guages are filtered (48ms)
        ✓ Pinned filter: metric value shows no data
        ✓ Pinned filter: tag cloud values are filtered
        ✓ Pinned filter: tsvb metric is filtered
        ✓ Pinned filter: tsvb top n is filtered (48ms)
        ✓ Pinned filter: saved search is filtered
        ✓ Pinned filter: vega is filtered (144ms)
      disabling a filter unfilters the data on
        ✓ Filter disabled: pie charts (3277ms)
        ✓ Filter disabled: area, bar and heatmap charts (109ms)
        ✓ Filter disabled: data tables (179ms)
        - Filter disabled: goal and guages
        ✓ Filter disabled: metric value
        ✓ Filter disabled: tag cloud (54ms)
        ✓ Filter disabled: tsvb metric
        ✓ Filter disabled: tsvb top n (48ms)
        ✓ Filter disabled: tsvb markdown
        ✓ Filter disabled: saved search is filtered
        ✓ Filter disabled: vega is filtered (156ms)
    nested filtering
      ✓ visualization saved with a query filters data (13582ms)
      ✓ Nested visualization filter pills filters data as expected (2897ms)
      ✓ Removing filter pills and query unfiters data as expected (4093ms)
      ✓ Pie chart linked to saved search filters data (3206ms)
      ✓ Pie chart linked to saved search filters shows no data with conflicting dashboard query (850ms)


  37 passing (1m)
  1 pending


  (Results)

  ┌────────────────────────────────────────────────────────────────────────────────────────────────┐
  │ Tests:        38                                                                               │
  │ Passing:      37                                                                               │
  │ Failing:      0                                                                                │
  │ Pending:      1                                                                                │
  │ Skipped:      0                                                                                │
  │ Screenshots:  0                                                                                │
  │ Video:        true                                                                             │
  │ Duration:     1 minute, 23 seconds                                                             │
  │ Spec Ran:     core-opensearch-dashboards/vanilla-opensearch-dashboards/dashboard_filtering_spe │
  │               c.js                                                                             │
  └────────────────────────────────────────────────────────────────────────────────────────────────┘

Signed-off-by: Tao Liu <liutaoaz@amazon.com>
@Flyingliuhub Flyingliuhub requested a review from a team as a code owner February 9, 2022 23:07
@Flyingliuhub Flyingliuhub merged commit d8ead25 into opensearch-project:main Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Filter disabled: goal and guages test is not stable
3 participants