Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skip flaky test and update document #92

Merged
merged 1 commit into from
Feb 9, 2022
Merged

skip flaky test and update document #92

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,13 +51,13 @@ $ npm uninstall @opensearch-dashboards-test/opensearch-dashboards-test-library &
You can run the cypress tests by cli:

```
$ npx cypress run --spec "cypress/integration/vanilla-opensearch-dashboards/*.js"
$ npx cypress run --spec "cypress/integration/core-opensearch-dashboards/vanilla-opensearch-dashboards/*.js"
```

By default, it uses headless mode (hide the broswer) You can turn on the browser display by:

```
$ npx cypress run --spec "cypress/integration/vanilla-opensearch-dashboards/*.js --headed"
$ npx cypress run --spec "cypress/integration/core-opensearch-dashboards/vanilla-opensearch-dashboards/*.js --headed"
```

You can also manually trigger the test via browser UI by:
Expand All @@ -69,7 +69,7 @@ $ npx cypress open
And you can override certain cypress config or environment variable by appling additional cli arguments, for example to override the baseUrl and OpensearchUrl to test a remote endpoint:

```
$ npx cypress run --spec "cypress/integration/vanilla-opensearch-dashboards/*.js" --env "openSearchUrl=https://foo.com" --config "baseUrl=https://foo.com/_dashboards"
$ npx cypress run --spec "cypress/integration/core-opensearch-dashboards/vanilla-opensearch-dashboards/*.js" --env "openSearchUrl=https://foo.com" --config "baseUrl=https://foo.com/_dashboards"
```

### Formatting
Expand Down
2 changes: 1 addition & 1 deletion ...tion/core-opensearch-dashboards/vanilla-opensearch-dashboards/dashboard_filtering_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,7 +265,7 @@ describe('dashboard filtering', () => {
);
});

it('Filter disabled: goal and guages', () => {
it.skip('Filter disabled: goal and guages', () => {
// Goal label should be 7,544, and the gauge label should be 39.958%%
// Inconsistency: original code says that the goal label should have "7,544",
// but sometimes the goal displays "7,565". It may have been related to a
Expand Down