Add support for approximate k-NN queries #548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Farr <tsfarr@amazon.com>
Signed-off-by: Thomas Farr <tsfarr@amazon.com>
Signed-off-by: Thomas Farr <tsfarr@amazon.com>
Signed-off-by: Thomas Farr <tsfarr@amazon.com>
Signed-off-by: Thomas Farr <tsfarr@amazon.com>
Xtansia
requested review from
reta,
Bukhtawar,
dblock,
szczepanczykd,
madhusudhankonda,
saratvemulapalli and
VachaShah
as code owners
Signed-off-by: Thomas Farr <tsfarr@amazon.com>
reta
reviewed
Jul 4, 2023
| @@ -1066,7 +1066,7 @@ protected void serializeInternal(JsonGenerator generator, JsonpMapper mapper) { | |||
|
|
|||
| } | |||
| if (this.knnAlgoParamEfSearch != null) { | |||
| generator.writeKey("knn.algo_param_ef_search"); | |||
| generator.writeKey("knn.algo_param.ef_search"); | |||
reta
reviewed
Jul 4, 2023
| @@ -1066,7 +1066,7 @@ protected void serializeInternal(JsonGenerator generator, JsonpMapper mapper) { | |||
|
|
|||
| } | |||
| if (this.knnAlgoParamEfSearch != null) { | |||
There was a problem hiding this comment.
Not related to this change, but it seems like a bunch of KNN index settings are missed:
"settings" : {
"index": {
"knn": true,
"knn.algo_param.m":90,
"knn.algo_param.ef_construction":200,
"knn.algo_param.ef_search":300
}
},
https://github.com/opensearch-project/k-NN/blob/main/RFC.md?plain=1
reta
reviewed
Jul 4, 2023
| @@ -28,8 +28,9 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) | |||
| ## [Unreleased 2.x] | |||
|
|
|||
| ### Added | |||
| - Add support for knn_vector field type ([#529](https://github.com/opensearch-project/opensearch-java/pull/524)) | |||
| - Add support for knn_vector field type ([#524](https://github.com/opensearch-project/opensearch-java/pull/524)) | |||
reta
previously approved these changes
Jul 4, 2023
Signed-off-by: Thomas Farr <xtansia@xtansia.com>
reta
approved these changes
Jul 5, 2023
Closed
dblock
approved these changes
Jul 5, 2023
VachaShah
added
backport 2.x
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 5, 2023
* Add Knn query type Signed-off-by: Thomas Farr <tsfarr@amazon.com> * Integration test Signed-off-by: Thomas Farr <tsfarr@amazon.com> * Checkstyle fix Signed-off-by: Thomas Farr <tsfarr@amazon.com> * Run unreleased test Signed-off-by: Thomas Farr <tsfarr@amazon.com> * Fixes Signed-off-by: Thomas Farr <tsfarr@amazon.com> * Assume knn plugin installed Signed-off-by: Thomas Farr <tsfarr@amazon.com> * Changelog Signed-off-by: Thomas Farr <tsfarr@amazon.com> * Add to QueryBuilders Signed-off-by: Thomas Farr <tsfarr@amazon.com> --------- Signed-off-by: Thomas Farr <tsfarr@amazon.com> Signed-off-by: Thomas Farr <xtansia@xtansia.com> (cherry picked from commit f427f27) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
reta
pushed a commit
that referenced
this pull request
Jul 5, 2023
* Add support for approximate k-NN queries (#548) * Add Knn query type Signed-off-by: Thomas Farr <tsfarr@amazon.com> * Integration test Signed-off-by: Thomas Farr <tsfarr@amazon.com> * Checkstyle fix Signed-off-by: Thomas Farr <tsfarr@amazon.com> * Run unreleased test Signed-off-by: Thomas Farr <tsfarr@amazon.com> * Fixes Signed-off-by: Thomas Farr <tsfarr@amazon.com> * Assume knn plugin installed Signed-off-by: Thomas Farr <tsfarr@amazon.com> * Changelog Signed-off-by: Thomas Farr <tsfarr@amazon.com> * Add to QueryBuilders Signed-off-by: Thomas Farr <tsfarr@amazon.com> --------- Signed-off-by: Thomas Farr <tsfarr@amazon.com> Signed-off-by: Thomas Farr <xtansia@xtansia.com> (cherry picked from commit f427f27) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Fixing compile errors Signed-off-by: Vacha Shah <vachshah@amazon.com> --------- Signed-off-by: Thomas Farr <tsfarr@amazon.com> Signed-off-by: Thomas Farr <xtansia@xtansia.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Vacha Shah <vachshah@amazon.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Vacha Shah <vachshah@amazon.com>
This was referenced Jul 5, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for the approximate k-NN query type to pair with the support for the
knn_vectortype added in #524. Along with a couple bug fixes for that support.Issues Resolved
#539
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.