Fixing InnerHits storedFields ("stored_fields") generated Json name. #781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: brentam <brentam.dev@gmail.com>
to "stored_fields" Signed-off-by: brentam <brentam.dev@gmail.com>
brentam
requested review from
reta,
Bukhtawar,
dblock,
szczepanczykd,
madhusudhankonda,
saratvemulapalli and
VachaShah
as code owners
Signed-off-by: brentam <brentam.dev@gmail.com>
Signed-off-by: brentam <brentam.dev@gmail.com>
reta
approved these changes
Dec 23, 2023
dblock
approved these changes
Dec 26, 2023
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-781-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 0729a92370cd8f81a394c38ccdf94567bfb92687
# Push it to GitHub
git push --set-upstream origin backport/backport-781-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.xThen, create a pull request where the |
reta
pushed a commit
to reta/opensearch-java
that referenced
this pull request
Jan 2, 2024
…pensearch-project#781) * dummy CHANGELOG.md Signed-off-by: brentam <brentam.dev@gmail.com> * corrected the InnerHits storedFields json field name to "stored_fields" Signed-off-by: brentam <brentam.dev@gmail.com> * adding correct PR information to CHANGELOG.md Signed-off-by: brentam <brentam.dev@gmail.com> * ran ./gradlew :java-client:spotlessApply Signed-off-by: brentam <brentam.dev@gmail.com> --------- Signed-off-by: brentam <brentam.dev@gmail.com> (cherry picked from commit 0729a92)
reta
pushed a commit
to reta/opensearch-java
that referenced
this pull request
Jan 2, 2024
…pensearch-project#781) * dummy CHANGELOG.md Signed-off-by: brentam <brentam.dev@gmail.com> * corrected the InnerHits storedFields json field name to "stored_fields" Signed-off-by: brentam <brentam.dev@gmail.com> * adding correct PR information to CHANGELOG.md Signed-off-by: brentam <brentam.dev@gmail.com> * ran ./gradlew :java-client:spotlessApply Signed-off-by: brentam <brentam.dev@gmail.com> --------- Signed-off-by: brentam <brentam.dev@gmail.com> (cherry picked from commit 0729a92) Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
dblock
pushed a commit
that referenced
this pull request
Jan 2, 2024
…781) (#794) * dummy CHANGELOG.md * corrected the InnerHits storedFields json field name to "stored_fields" * adding correct PR information to CHANGELOG.md * ran ./gradlew :java-client:spotlessApply --------- (cherry picked from commit 0729a92) Signed-off-by: brentam <brentam.dev@gmail.com> Signed-off-by: Andriy Redko <andriy.redko@aiven.io> Co-authored-by: brentam <56659702+brentam@users.noreply.github.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This will fix the InnerHits storedFields serialization/deserialization.
At the moment, InnerHits is generating/expecting the wrong json field name for "stored_fields".
It is actually using "stored_field" (singular).
Thus, Is not possible to create correct search requests that uses InnerHits with storedFields.
Issues Resolved
Will close #780
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.