Add "filter" to neural query #932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Grogdunn
requested review from
reta,
Bukhtawar,
dblock,
szczepanczykd,
madhusudhankonda,
saratvemulapalli and
VachaShah
as code owners
Signed-off-by: Lorenzo Caenazzo <lorenzo.caenazzo@optionfactory.net>
Signed-off-by: Lorenzo Caenazzo <lorenzo.caenazzo@optionfactory.net>
Signed-off-by: Lorenzo Caenazzo <lorenzo.caenazzo@optionfactory.net>
Signed-off-by: Lorenzo Caenazzo <lorenzo.caenazzo@optionfactory.net>
reta
previously approved these changes
Apr 10, 2024
Signed-off-by: Lorenzo Caenazzo <lorenzo.caenazzo@optionfactory.net>
reta
reviewed
Apr 10, 2024
Co-authored-by: Andriy Redko <drreta@gmail.com> Signed-off-by: Grogdunn <frzlollo@gmail.com>
reta
approved these changes
Apr 10, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 10, 2024
* 🩹 add filter to neural query Signed-off-by: Lorenzo Caenazzo <lorenzo.caenazzo@optionfactory.net> * CHANGELOG.md Signed-off-by: Lorenzo Caenazzo <lorenzo.caenazzo@optionfactory.net> * 💚 spotless fix Signed-off-by: Lorenzo Caenazzo <lorenzo.caenazzo@optionfactory.net> * 💚 spotless fix, jdk8 check Signed-off-by: Lorenzo Caenazzo <lorenzo.caenazzo@optionfactory.net> * 💚 spotless fix Signed-off-by: Lorenzo Caenazzo <lorenzo.caenazzo@optionfactory.net> * Update CHANGELOG.md Co-authored-by: Andriy Redko <drreta@gmail.com> Signed-off-by: Grogdunn <frzlollo@gmail.com> --------- Signed-off-by: Lorenzo Caenazzo <lorenzo.caenazzo@optionfactory.net> Signed-off-by: Grogdunn <frzlollo@gmail.com> Co-authored-by: Andriy Redko <drreta@gmail.com> (cherry picked from commit bc78613) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
reta
added a commit
that referenced
this pull request
Apr 10, 2024
* 🩹 add filter to neural query * CHANGELOG.md * 💚 spotless fix * 💚 spotless fix, jdk8 check * 💚 spotless fix * Update CHANGELOG.md --------- (cherry picked from commit bc78613) Signed-off-by: Lorenzo Caenazzo <lorenzo.caenazzo@optionfactory.net> Signed-off-by: Grogdunn <frzlollo@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Andriy Redko <drreta@gmail.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support to internal "filter" object into NeuralQuery.
Simple fix to add "filter" into, same as Knn.