Added delete task API. #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Function accepts task id and performs deleting. Signed-off-by: Nurlan <nabzalbekov0@gmail.com>
Nurlanprog
requested review from
dhrubo-os,
greaa-aws and
ylwu-amzn
as code owners
dhrubo-os
approved these changes
Mar 30, 2023
b4sjoo
reviewed
Mar 30, 2023
| try: | ||
| delete_task_obj = ml_client.delete_task(task_id) | ||
| assert delete_task_obj.get("result") == "deleted" | ||
| except: # noqa: E722 |
There was a problem hiding this comment.
Maybe we should specify the exception here to avoid a too broad except
b4sjoo
approved these changes
Mar 30, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 30, 2023
Function accepts task id and performs deleting. Signed-off-by: Nurlan <nabzalbekov0@gmail.com> (cherry picked from commit 2c73825)
This was referenced Mar 30, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 30, 2023
Function accepts task id and performs deleting. Signed-off-by: Nurlan <nabzalbekov0@gmail.com> (cherry picked from commit 2c73825)
dhrubo-os
pushed a commit
that referenced
this pull request
Mar 31, 2023
dhrubo-os
pushed a commit
that referenced
this pull request
Mar 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Function accepts task id and performs deleting task.
Issues Resolved
#104
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.