Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] MLCommons Integration #104

Closed
dhrubo-os opened this issue Mar 9, 2023 · 6 comments
Closed

[FEATURE] MLCommons Integration #104

dhrubo-os opened this issue Mar 9, 2023 · 6 comments
Labels
CCI enhancement New feature or request

Comments

@dhrubo-os
Copy link
Collaborator

dhrubo-os commented Mar 9, 2023

Is your feature request related to a problem?

We want to integrate all the ML-Commons api to opensearch-py-ml.

Right now following apis are supported:

  1. Upload Model
  2. Load model
  3. Get task information
  4. Get model information
  5. Unload model
  6. Delete model

We want to have support for following apis:

  1. Train --> https://opensearch.org/docs/latest/ml-commons-plugin/api/#train-model
  2. Predict --> https://opensearch.org/docs/latest/ml-commons-plugin/api/#predict
  3. Train and Predict --> https://opensearch.org/docs/latest/ml-commons-plugin/api/#train-and-predict
  4. Search Task --> https://opensearch.org/docs/latest/ml-commons-plugin/api/#search-task
  5. Delete Task --> https://opensearch.org/docs/latest/ml-commons-plugin/api/#delete-task ---------> This is done.
  6. Profile api --> https://opensearch.org/docs/latest/ml-commons-plugin/api/#profile
  7. Search model --> https://opensearch.org/docs/latest/ml-commons-plugin/api/#search-model
  8. Execute api --> https://opensearch.org/docs/latest/ml-commons-plugin/api/#execute : For testing after development, we can use this request:
POST _plugins/_ml/_execute/local_sample_calculator
{
    "operation": "max",
    "input_data": [1.0, 2.0, 3.0]
}

So, to implement this request python function can expect two variables:

  1. algorithm name
  2. input request --> here we need to check the input validation like if the input string is a valid json object or not.
@dhrubo-os dhrubo-os added enhancement New feature or request untriaged CCI and removed untriaged labels Mar 9, 2023
This was referenced Mar 19, 2023
@Merey1508 Merey1508 mentioned this issue Mar 22, 2023
5 tasks
@Merey1508
Copy link
Contributor

Hi, everyone! I wanted to let you know that I am currently focusing my efforts on the Profile API (№6).

@dhrubo-os, I've noticed that we have two identical tasks (№4 and №7) in our API support list. Perhaps we can review and clarify if there are any differences between the two, or if one of them can be removed to avoid confusion?

@Nurlanprog
Copy link
Contributor

I am working on delete task

@dhrubo-os
Copy link
Collaborator Author

dhrubo-os commented Mar 26, 2023

Thanks. @Nurlanprog

@dhrubo-os
Copy link
Collaborator Author

Hi, everyone! I wanted to let you know that I am currently focusing my efforts on the Profile API (№6).

@dhrubo-os, I've noticed that we have two identical tasks (№4 and №7) in our API support list. Perhaps we can review and clarify if there are any differences between the two, or if one of them can be removed to avoid confusion?

@Merey1508 Yes, you are right. Removed the duplicate task. Thanks

This was referenced Mar 28, 2023
@Assylnur
Copy link

Assylnur commented Mar 30, 2023

Hello, everyone! I am working on Train (1) and predict (2) apis

@dhrubo-os
Copy link
Collaborator Author

Few of the tasks are completed and new issues are created for for the remaining tasks. We can close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCI enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants