Configure spotless to cleanup misc files #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Widdis <widdis@gmail.com>
Signed-off-by: Daniel Widdis <widdis@gmail.com>
dbwiddis
force-pushed
the
spotless
branch
2 times, most recently
from
3bcf42b
to
a101c44
Compare
Signed-off-by: Daniel Widdis <widdis@gmail.com>
owaiskazi19
reviewed
Oct 13, 2022
owaiskazi19
reviewed
Oct 13, 2022
Signed-off-by: Daniel Widdis <widdis@gmail.com>
owaiskazi19
previously approved these changes
Oct 14, 2022
Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
saratvemulapalli
approved these changes
Oct 14, 2022
joshpalis
approved these changes
Oct 14, 2022
|
@saratvemulapalli @owaiskazi19 @joshpalis
Following completion of Code Hygeine, kicked off Gradle Build
|
This was referenced Oct 17, 2022
kokibas
pushed a commit
to kokibas/opensearch-sdk-java
that referenced
this pull request
Mar 17, 2023
* Configure spotless to cleanup misc files Signed-off-by: Daniel Widdis <widdis@gmail.com> * Remove trailing spaces Signed-off-by: Daniel Widdis <widdis@gmail.com> * Remove linelint, only trigger gradle check if spotless check passes Signed-off-by: Daniel Widdis <widdis@gmail.com> * Remove linelint config file Signed-off-by: Daniel Widdis <widdis@gmail.com> Signed-off-by: Daniel Widdis <widdis@gmail.com> Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com> Co-authored-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Daniel Widdis widdis@gmail.com
Description
It was faster for me to configure spotless to add newlines to the openapi files I keep exporting than to figure out which one needed me to open the editor and add a newline to.
I intentionally made the initial PR with a failing spotless issue in one of the new misc files and it failed, indicating that the gradle check is now redundant with the linelint check.
Accordingly I have removed the linelint check and changed the Code Hygiene workflow to run spotlessCheck, which also checks for other spotless issues (trailing spaces, format, etc.)
I also set up the workflow so that the Gradle Check will only run upon successful completion of the hygiene check. (NOTE: The workflow_run will only trigger once this is merged to main, so you don't see the gradle check in the last run of this PR; however, it will run once merged.). See this comment for a more detailed explanation.
Issues Resolved
Fixes #110
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.