Replace @elastic/datemath with @opensearch/datemath #204

BSFishy · 2023-01-09T20:02:52Z

Signed-off-by: Matt Provost provomat@amazon.com

Description

Replaces @elastic/datemath with @opensearch/datemath from OSD. This helps with our legal compliance and will help make it easier to fix security vulnerabilities in the future.

Issues Resolved

#129

Check List

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Matt Provost <provomat@amazon.com>

AMoo-Miki · 2023-01-12T22:32:05Z

package.json

    "@elastic/eslint-config-kibana": "^0.15.0",
+    "@opensearch/datemath": "file:./packages/opensearch-datemath",


This should be named oui-datemath.

@BSFishy could you check what should be the name of this package?

This is set here to reflect the package's original name:

oui/packages/opensearch-datemath/package.json

Line 2 in 5f9f417

"name": "@opensearch/datemath",

Not sure if this should actually change since it is directly copied from OSD repo

Since the names we wanted are already taken, it doesn't make sense to hold this on just a simple name which is used internally only.

Signed-off-by: Matt Provost <provomat@amazon.com>

joshuarrrr

I didn't review the actual implementation of the openserach-datemath package, which I assume was directly forked. If there are functional changes there, let me know and I'll give it a second look.

joshuarrrr · 2023-06-20T21:13:41Z

packages/opensearch-datemath/tsconfig.json

+  "include": [
+    "index.d.ts"
+  ]
+}


nit, missing blank line EOF

opensearch-trigger-bot · 2023-06-20T21:26:35Z

The backport to 1.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-1.x 1.x
# Navigate to the new working tree
pushd ../.worktrees/backport-1.x
# Create a new branch
git switch --create backport/backport-204-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 175b8cfe49134e24d87c2328a9f1fec614592824
# Push it to GitHub
git push --set-upstream origin backport/backport-204-to-1.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-1.x

Then, create a pull request where the base branch is 1.x and the compare/head branch is backport/backport-204-to-1.x.

…ct#204) * Replace @elastic/datemath with @opensearch/datemath Signed-off-by: Matt Provost <provomat@amazon.com> * Clean up Signed-off-by: Matt Provost <provomat@amazon.com> --------- Signed-off-by: Matt Provost <provomat@amazon.com>

* Remove beta badge accent color (#99) Signed-off-by: Matt Provost <provomat@amazon.com> Signed-off-by: Matt Provost <provomat@amazon.com> * OUI combo box refine (#183) * Added a prop clearOnBlur Signed-off-by: AbhishekReddy1127 <nallamsa@amazon.com> * Added example for prop clearOnBlur Signed-off-by: AbhishekReddy1127 <nallamsa@amazon.com> --------- Signed-off-by: AbhishekReddy1127 <nallamsa@amazon.com> * Update Comment List Docs (#252) Signed-off-by: Matt Provost <provomat@amazon.com> * Updated the section Collapsable Nav (#330) Signed-off-by: AbhishekReddy1127 <nallamsa@amazon.com> Co-authored-by: Sean Neumann <1413295+seanneumann@users.noreply.github.com> * Updated the kibana to opensearch_dashboards (#343) Signed-off-by: AbhishekReddy1127 <nallamsa@amazon.com> * Updated the section drag and drop (#514) Signed-off-by: AbhishekReddy1127 <nallamsa@amazon.com> Co-authored-by: Sean Neumann <1413295+seanneumann@users.noreply.github.com> * Update @svgr/core and @svgr/plugin-svgo (#594) (#649) Signed-off-by: Andrey Myssak <andreymyssak@gmail.com> Co-authored-by: Sergey Myssak <sergey.myssak@gmail.com> * Migrate from faker to @faker-js/faker (#594) (#655) Signed-off-by: Andrey Myssak <andreymyssak@gmail.com> Co-authored-by: Sergey Myssak <sergey.myssak@gmail.com> * Bump @faker-js/faker to v8 (#594) (#768) Signed-off-by: Andrey Myssak <andreymyssak@gmail.com> * change beta to experimental (#383) Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> Co-authored-by: Sean Neumann <1413295+seanneumann@users.noreply.github.com> * Normalize interlink URL usage (#698) (#720) Signed-off-by: Sergey Myssak <sergey.myssak@gmail.com> Co-authored-by: Andrey Myssak <andreymyssak@gmail.com> * [CCI] Add `useDeprecatedPropWarning` and align with `deprecated` hoc (#762) * Add useDeprecatedPropWarning and align with deprecated hoc (#761) Co-authored-by: Andrey Myssak <andreymyssak@gmail.com> Signed-off-by: Sergey Myssak <sergey.myssak@gmail.com> * Add multiple props to useDeprecatedPropWarning and pass getMessage to deprecatedComponentWarning (#761) Co-authored-by: Andrey Myssak <andreymyssak@gmail.com> Signed-off-by: Sergey Myssak <sergey.myssak@gmail.com> * Use ExclusiveUnion in interfaces (#761) Co-authored-by: Andrey Myssak <andreymyssak@gmail.com> Signed-off-by: Sergey Myssak <sergey.myssak@gmail.com> --------- Signed-off-by: Sergey Myssak <sergey.myssak@gmail.com> Co-authored-by: Andrey Myssak <andreymyssak@gmail.com> * Update the default branch (#584) (#798) Signed-off-by: Andrey Myssak <andreymyssak@gmail.com> Co-authored-by: Sergey Myssak <sergey.myssak@gmail.com> * [OuiComboBox] Add docs for icon and revise example for clearOnBlur (#806) Signed-off-by: Miki <miki@amazon.com> * Updated bug issue template (#764) * Update bug issue template Signed-off-by: Sirazh Gabdullin <sirazh.gabdullin@nu.edu.kz> * Add spacing Signed-off-by: Sirazh Gabdullin <sirazh.gabdullin@nu.edu.kz> --------- Signed-off-by: Sirazh Gabdullin <sirazh.gabdullin@nu.edu.kz> * Move OuiBottomBar default inline styles to the CSS file (#693) (#694) Signed-off-by: Sergey Myssak <sergey.myssak@gmail.com> Co-authored-by: Andrey Myssak <andreymyssak@gmail.com> * [CCI] Update react-window and react-virtualized-auto-sizer dependencies (#652) * Update react-window (#594) * Update react-virtualized-auto-sizer (#594) Co-authored-by: Sergey Myssak <sergey.myssak@gmail.com> Signed-off-by: Andrey Myssak <andreymyssak@gmail.com> --------- Signed-off-by: Andrey Myssak <andreymyssak@gmail.com> Co-authored-by: Sergey Myssak <sergey.myssak@gmail.com> * Update dropzone (#594) (#651) Signed-off-by: Andrey Myssak <andreymyssak@gmail.com> Co-authored-by: Sergey Myssak <sergey.myssak@gmail.com> * Updated the section Beta badge (#338) Signed-off-by: AbhishekReddy1127 <nallamsa@amazon.com> * Add props and examples for the combobox (#660) Signed-off-by: AbhishekReddy1127 <nallamsa@amazon.com> * Updated the links in the section Markdown Format (#365) Signed-off-by: AbhishekReddy1127 <nallamsa@amazon.com> * Update Notification event page (#549) Signed-off-by: manasvinibs <manasvis@amazon.com> Co-authored-by: Sean Neumann <1413295+seanneumann@users.noreply.github.com> * Updated the content in the section Messages and loading (#350) Signed-off-by: AbhishekReddy1127 <nallamsa@amazon.com> * Updated the content in the section suggest (#347) Signed-off-by: AbhishekReddy1127 <nallamsa@amazon.com> * Update affiliation of Andrey and Sergey (#794) Signed-off-by: Matt Provost <provomat@amazon.com> * [CCI] Update dependencies (#716) * Update dependencies (#594) Co-authored-by: Sergey Myssak <sergey.myssak@gmail.com> Signed-off-by: Andrey Myssak <andreymyssak@gmail.com> * Bump @axe-core/puppeteer to v4.6.1 and puppeteer to v19.11.1 Signed-off-by: Andrey Myssak <andreymyssak@gmail.com> * Bump react-window, tabbable and rimraf patch versions Signed-off-by: Andrey Myssak <andreymyssak@gmail.com> * Bump @svgr/core, @svgr/plugin-svgo and @svgr/plugin-jsx to v8 Signed-off-by: Andrey Myssak <andreymyssak@gmail.com> --------- Signed-off-by: Andrey Myssak <andreymyssak@gmail.com> Co-authored-by: Sergey Myssak <sergey.myssak@gmail.com> * Replace @elastic/datemath with @opensearch/datemath (#204) * Replace @elastic/datemath with @opensearch/datemath Signed-off-by: Matt Provost <provomat@amazon.com> * Clean up Signed-off-by: Matt Provost <provomat@amazon.com> --------- Signed-off-by: Matt Provost <provomat@amazon.com> * Bump semver to 7.5.3 (#855) * Bump semver to 7.5.3 Signed-off-by: Matt Provost <provomat@amazon.com> * Add resolution to eslint plugin Signed-off-by: Matt Provost <provomat@amazon.com> --------- Signed-off-by: Matt Provost <provomat@amazon.com> * Remove Split button from OUI docs (#805) (#812) Signed-off-by: Sergey Myssak <sergey.myssak@gmail.com> Co-authored-by: Andrey Myssak <andreymyssak@gmail.com> * Updated the text in the section ErrorBoundary (#366) Signed-off-by: AbhishekReddy1127 <nallamsa@amazon.com> * Docs site changes (#96) * first change Signed-off-by: Kroosh Crusius <kroosh@amazon.com> * undoing first change Signed-off-by: Kroosh Crusius <kroosh@amazon.com> * making a sample change to test commit success or failure Signed-off-by: Kroosh Crusius <kroosh@amazon.com> * undoes sample change for testing Signed-off-by: Kroosh Crusius <kroosh@amazon.com> * minor changes for tone, deleted references to starter projects as they are not maintained by OSD Signed-off-by: Kroosh Crusius <kroosh@amazon.com> * Delete OUI.iml Removing as included accidentally. * Delete oui.iml Removing as included accidentally. * Update getting_started.md Updated link to node version manager to avoid redirect --------- Signed-off-by: Kroosh Crusius <kroosh@amazon.com> * Update getting_started.md to remove elastic reference and other changes (#502) Signed-off-by: manasvinibs <manasvis@amazon.com> * Removed GitHub column from all the tables (#371) Signed-off-by: AbhishekReddy1127 <nallamsa@amazon.com> * Updated the content and Icons in the section CssUtilityClasses (#368) Signed-off-by: AbhishekReddy1127 <nallamsa@amazon.com> * Delete Kibana reference in commands (#535) * Delete kibana reference in commands Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * Change the tgz naming to opensearch Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * Updated doc site link and github reference Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * Change URL to only include domain Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> --------- Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> Co-authored-by: Sean Neumann <1413295+seanneumann@users.noreply.github.com> * fixed invalid link in FAQ.md (#751) Signed-off-by: Aigerim Suleimenova <aigerim.suleimenova27@gmail.com> --------- Signed-off-by: Matt Provost <provomat@amazon.com> Signed-off-by: AbhishekReddy1127 <nallamsa@amazon.com> Signed-off-by: Andrey Myssak <andreymyssak@gmail.com> Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> Signed-off-by: Sergey Myssak <sergey.myssak@gmail.com> Signed-off-by: Miki <miki@amazon.com> Signed-off-by: Sirazh Gabdullin <sirazh.gabdullin@nu.edu.kz> Signed-off-by: manasvinibs <manasvis@amazon.com> Signed-off-by: Kroosh Crusius <kroosh@amazon.com> Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> Signed-off-by: Aigerim Suleimenova <aigerim.suleimenova27@gmail.com> Co-authored-by: Matt Provost <provomat@amazon.com> Co-authored-by: Abhishek Reddy <62020972+AbhishekReddy1127@users.noreply.github.com> Co-authored-by: Sean Neumann <1413295+seanneumann@users.noreply.github.com> Co-authored-by: Andrey Myssak <40265277+andreymyssak@users.noreply.github.com> Co-authored-by: Sergey Myssak <sergey.myssak@gmail.com> Co-authored-by: Ashwin P Chandran <ashwinpc1993@gmail.com> Co-authored-by: Andrey Myssak <andreymyssak@gmail.com> Co-authored-by: Sirazh Gabdullin <sirazh.gabdullin@nu.edu.kz> Co-authored-by: Manasvini B Suryanarayana <manasvis@amazon.com> Co-authored-by: Kroosh <kroosh@amazon.com> Co-authored-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com> Co-authored-by: Aigerim Suleimenova <aigerim.suleimenova27@gmail.com>

This reverts commit 175b8cf.

joshuarrrr · 2023-09-05T20:12:37Z

backported in #872

Replace @elastic/datemath with @opensearch/datemath

5f9f417

Signed-off-by: Matt Provost <provomat@amazon.com>

BSFishy added dependencies Pull requests that update a dependency file refactor labels Jan 9, 2023

BSFishy requested a review from a team as a code owner January 9, 2023 20:02

BSFishy self-assigned this Jan 9, 2023

AMoo-Miki reviewed Jan 12, 2023

View reviewed changes

BSFishy mentioned this pull request Feb 28, 2023

[Docs] Update getting_started.md to remove elastic reference and other changes #502

Merged

1 task

Merge branch 'main' into update_datemath

8ac4fe3

Signed-off-by: Matt Provost <provomat@amazon.com>

BSFishy requested review from seanneumann, rednaksi91, KrooshalUX, bandinib-amzn, ashwin-pc, joshuarrrr, andreymyssak and SergeyMyssak as code owners June 20, 2023 20:36

Clean up

5dc33d0

Signed-off-by: Matt Provost <provomat@amazon.com>

AMoo-Miki approved these changes Jun 20, 2023

View reviewed changes

AMoo-Miki added the backport 1.x label Jun 20, 2023

joshuarrrr approved these changes Jun 20, 2023

View reviewed changes

packages/opensearch-datemath/tsconfig.json

"include": [

"index.d.ts"

]

}

Copy link

Member

joshuarrrr Jun 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit, missing blank line EOF

BSFishy merged commit 175b8cf into opensearch-project:main Jun 20, 2023
5 checks passed

BSFishy deleted the update_datemath branch June 20, 2023 21:25

AMoo-Miki added the failed backport label Jul 2, 2023

AMoo-Miki mentioned this pull request Jul 2, 2023

[Manual][backport 1.x] Several changes #872

Merged

7 tasks

joshuarrrr added a commit that referenced this pull request Aug 29, 2023

Revert "Replace @elastic/datemath with @opensearch/datemath (#204)"

e904663

This reverts commit 175b8cf.

joshuarrrr removed the failed backport label Sep 5, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Replace @elastic/datemath with @opensearch/datemath #204

Replace @elastic/datemath with @opensearch/datemath #204

BSFishy commented Jan 9, 2023

AMoo-Miki Jan 12, 2023

ananzh Feb 28, 2023

BSFishy Feb 28, 2023

AMoo-Miki Jun 20, 2023

joshuarrrr left a comment

joshuarrrr Jun 20, 2023

opensearch-trigger-bot bot commented Jun 20, 2023

joshuarrrr commented Sep 5, 2023

		"@elastic/eslint-config-kibana": "^0.15.0",
		"@opensearch/datemath": "file:./packages/opensearch-datemath",

Replace @elastic/datemath with @opensearch/datemath #204

Replace @elastic/datemath with @opensearch/datemath #204

Conversation

BSFishy commented Jan 9, 2023

Description

Issues Resolved

Check List

AMoo-Miki Jan 12, 2023

Choose a reason for hiding this comment

ananzh Feb 28, 2023

Choose a reason for hiding this comment

BSFishy Feb 28, 2023

Choose a reason for hiding this comment

AMoo-Miki Jun 20, 2023

Choose a reason for hiding this comment

joshuarrrr left a comment

Choose a reason for hiding this comment

joshuarrrr Jun 20, 2023

Choose a reason for hiding this comment

opensearch-trigger-bot bot commented Jun 20, 2023

joshuarrrr commented Sep 5, 2023