Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CCI] Migrate from faker to @faker-js/faker #655

Merged

Conversation

andreymyssak
Copy link
Collaborator

@andreymyssak andreymyssak commented Apr 1, 2023

Description

Migrate from faker to @faker-js/faker.

The main goal is not to update faker as done in #653, but to discard it immediately and migrate to @faker-js/faker.

Issues Resolved

#594

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • All tests pass
    • yarn lint
    • yarn test-unit
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Co-authored-by: Sergey Myssak <sergey.myssak@gmail.com>
Signed-off-by: Andrey Myssak <andreymyssak@gmail.com>
@andreymyssak andreymyssak requested a review from a team as a code owner April 1, 2023 08:52
@andreymyssak andreymyssak mentioned this pull request Apr 1, 2023
6 tasks
Copy link
Contributor

@BSFishy BSFishy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, looks great!

@@ -13543,7 +13543,7 @@ request-promise-native@^1.0.5:
stealthy-require "^1.1.1"
tough-cookie "^2.3.3"

request@^2.87.0, request@^2.88.0:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is changed in #652 as well, need to keep an eye on it so we don't have merge conflicts

Copy link
Member

@ashwin-pc ashwin-pc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for the change. Great job breaking down the PR into more manageable ones.

@ashwin-pc ashwin-pc added the CCI College Contributor Initiative label Apr 7, 2023
@joshuarrrr joshuarrrr merged commit ff45ae5 into opensearch-project:main Apr 12, 2023
5 checks passed
AMoo-Miki pushed a commit to AMoo-Miki/oui that referenced this pull request Jul 2, 2023
…earch-project#655)

Signed-off-by: Andrey Myssak <andreymyssak@gmail.com>
Co-authored-by: Sergey Myssak <sergey.myssak@gmail.com>
AMoo-Miki added a commit that referenced this pull request Jul 15, 2023
* Remove beta badge accent color (#99)

Signed-off-by: Matt Provost <provomat@amazon.com>

Signed-off-by: Matt Provost <provomat@amazon.com>

* OUI combo box refine (#183)

* Added a prop clearOnBlur

Signed-off-by: AbhishekReddy1127 <nallamsa@amazon.com>

* Added example for prop clearOnBlur

Signed-off-by: AbhishekReddy1127 <nallamsa@amazon.com>

---------

Signed-off-by: AbhishekReddy1127 <nallamsa@amazon.com>

* Update Comment List Docs (#252)

Signed-off-by: Matt Provost <provomat@amazon.com>

* Updated the section Collapsable Nav (#330)

Signed-off-by: AbhishekReddy1127 <nallamsa@amazon.com>
Co-authored-by: Sean Neumann <1413295+seanneumann@users.noreply.github.com>

* Updated the kibana to opensearch_dashboards (#343)

Signed-off-by: AbhishekReddy1127 <nallamsa@amazon.com>

* Updated the section drag and drop (#514)

Signed-off-by: AbhishekReddy1127 <nallamsa@amazon.com>
Co-authored-by: Sean Neumann <1413295+seanneumann@users.noreply.github.com>

* Update @svgr/core and @svgr/plugin-svgo (#594) (#649)

Signed-off-by: Andrey Myssak <andreymyssak@gmail.com>
Co-authored-by: Sergey Myssak <sergey.myssak@gmail.com>

* Migrate from faker to @faker-js/faker (#594) (#655)

Signed-off-by: Andrey Myssak <andreymyssak@gmail.com>
Co-authored-by: Sergey Myssak <sergey.myssak@gmail.com>

* Bump @faker-js/faker to v8 (#594) (#768)

Signed-off-by: Andrey Myssak <andreymyssak@gmail.com>

* change beta to experimental (#383)

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
Co-authored-by: Sean Neumann <1413295+seanneumann@users.noreply.github.com>

* Normalize interlink URL usage (#698) (#720)

Signed-off-by: Sergey Myssak <sergey.myssak@gmail.com>
Co-authored-by: Andrey Myssak <andreymyssak@gmail.com>

* [CCI] Add `useDeprecatedPropWarning` and align with `deprecated` hoc (#762)

* Add useDeprecatedPropWarning and align with deprecated hoc (#761)

Co-authored-by: Andrey Myssak <andreymyssak@gmail.com>
Signed-off-by: Sergey Myssak <sergey.myssak@gmail.com>

* Add multiple props to useDeprecatedPropWarning and pass getMessage to deprecatedComponentWarning (#761)

Co-authored-by: Andrey Myssak <andreymyssak@gmail.com>
Signed-off-by: Sergey Myssak <sergey.myssak@gmail.com>

* Use ExclusiveUnion in interfaces (#761)

Co-authored-by: Andrey Myssak <andreymyssak@gmail.com>
Signed-off-by: Sergey Myssak <sergey.myssak@gmail.com>

---------

Signed-off-by: Sergey Myssak <sergey.myssak@gmail.com>
Co-authored-by: Andrey Myssak <andreymyssak@gmail.com>

* Update the default branch (#584) (#798)

Signed-off-by: Andrey Myssak <andreymyssak@gmail.com>
Co-authored-by: Sergey Myssak <sergey.myssak@gmail.com>

* [OuiComboBox] Add docs for icon and revise example for clearOnBlur (#806)

Signed-off-by: Miki <miki@amazon.com>

* Updated bug issue template (#764)

* Update bug issue template

Signed-off-by: Sirazh Gabdullin <sirazh.gabdullin@nu.edu.kz>

* Add spacing

Signed-off-by: Sirazh Gabdullin <sirazh.gabdullin@nu.edu.kz>

---------

Signed-off-by: Sirazh Gabdullin <sirazh.gabdullin@nu.edu.kz>

* Move OuiBottomBar default inline styles to the CSS file (#693) (#694)

Signed-off-by: Sergey Myssak <sergey.myssak@gmail.com>
Co-authored-by: Andrey Myssak <andreymyssak@gmail.com>

* [CCI] Update react-window and react-virtualized-auto-sizer dependencies (#652)

* Update react-window (#594)
* Update react-virtualized-auto-sizer (#594)

Co-authored-by: Sergey Myssak <sergey.myssak@gmail.com>
Signed-off-by: Andrey Myssak <andreymyssak@gmail.com>

---------

Signed-off-by: Andrey Myssak <andreymyssak@gmail.com>
Co-authored-by: Sergey Myssak <sergey.myssak@gmail.com>

* Update dropzone (#594) (#651)

Signed-off-by: Andrey Myssak <andreymyssak@gmail.com>
Co-authored-by: Sergey Myssak <sergey.myssak@gmail.com>

* Updated the section Beta badge (#338)

Signed-off-by: AbhishekReddy1127 <nallamsa@amazon.com>

* Add props and examples for the combobox (#660)

Signed-off-by: AbhishekReddy1127 <nallamsa@amazon.com>

* Updated the links in the section Markdown Format (#365)

Signed-off-by: AbhishekReddy1127 <nallamsa@amazon.com>

* Update Notification event page (#549)

Signed-off-by: manasvinibs <manasvis@amazon.com>
Co-authored-by: Sean Neumann <1413295+seanneumann@users.noreply.github.com>

* Updated the content in the section Messages and loading (#350)

Signed-off-by: AbhishekReddy1127 <nallamsa@amazon.com>

* Updated the content in the section suggest (#347)

Signed-off-by: AbhishekReddy1127 <nallamsa@amazon.com>

* Update affiliation of Andrey and Sergey (#794)

Signed-off-by: Matt Provost <provomat@amazon.com>

* [CCI] Update dependencies (#716)

* Update dependencies (#594)

Co-authored-by: Sergey Myssak <sergey.myssak@gmail.com>
Signed-off-by: Andrey Myssak <andreymyssak@gmail.com>

* Bump @axe-core/puppeteer to v4.6.1 and puppeteer to v19.11.1

Signed-off-by: Andrey Myssak <andreymyssak@gmail.com>

* Bump react-window, tabbable and rimraf patch versions

Signed-off-by: Andrey Myssak <andreymyssak@gmail.com>

* Bump @svgr/core, @svgr/plugin-svgo and @svgr/plugin-jsx to v8

Signed-off-by: Andrey Myssak <andreymyssak@gmail.com>

---------

Signed-off-by: Andrey Myssak <andreymyssak@gmail.com>
Co-authored-by: Sergey Myssak <sergey.myssak@gmail.com>

* Replace @elastic/datemath with @opensearch/datemath (#204)

* Replace @elastic/datemath with @opensearch/datemath

Signed-off-by: Matt Provost <provomat@amazon.com>

* Clean up

Signed-off-by: Matt Provost <provomat@amazon.com>

---------

Signed-off-by: Matt Provost <provomat@amazon.com>

* Bump semver to 7.5.3 (#855)

* Bump semver to 7.5.3

Signed-off-by: Matt Provost <provomat@amazon.com>

* Add resolution to eslint plugin

Signed-off-by: Matt Provost <provomat@amazon.com>

---------

Signed-off-by: Matt Provost <provomat@amazon.com>

* Remove Split button from OUI docs (#805) (#812)

Signed-off-by: Sergey Myssak <sergey.myssak@gmail.com>
Co-authored-by: Andrey Myssak <andreymyssak@gmail.com>

* Updated the text in the section ErrorBoundary (#366)

Signed-off-by: AbhishekReddy1127 <nallamsa@amazon.com>

* Docs site changes (#96)

* first change

Signed-off-by: Kroosh Crusius <kroosh@amazon.com>

* undoing first change

Signed-off-by: Kroosh Crusius <kroosh@amazon.com>

* making a sample change to test commit success or failure

Signed-off-by: Kroosh Crusius <kroosh@amazon.com>

* undoes sample change for testing

Signed-off-by: Kroosh Crusius <kroosh@amazon.com>

* minor changes for tone, deleted references to starter projects as they are not maintained by OSD

Signed-off-by: Kroosh Crusius <kroosh@amazon.com>

* Delete OUI.iml

Removing as included accidentally.

* Delete oui.iml

Removing as included accidentally.

* Update getting_started.md

Updated link to node version manager to avoid redirect

---------

Signed-off-by: Kroosh Crusius <kroosh@amazon.com>

* Update getting_started.md to remove elastic reference and other changes (#502)

Signed-off-by: manasvinibs <manasvis@amazon.com>

* Removed GitHub column from all the tables (#371)

Signed-off-by: AbhishekReddy1127 <nallamsa@amazon.com>

* Updated the content and Icons in the section CssUtilityClasses (#368)

Signed-off-by: AbhishekReddy1127 <nallamsa@amazon.com>

* Delete Kibana reference in commands (#535)

* Delete kibana reference in commands

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* Change the tgz naming to opensearch

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* Updated doc site link and github reference

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* Change URL to only include domain

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

---------

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
Co-authored-by: Sean Neumann <1413295+seanneumann@users.noreply.github.com>

* fixed invalid link in FAQ.md (#751)

Signed-off-by: Aigerim Suleimenova <aigerim.suleimenova27@gmail.com>

---------

Signed-off-by: Matt Provost <provomat@amazon.com>
Signed-off-by: AbhishekReddy1127 <nallamsa@amazon.com>
Signed-off-by: Andrey Myssak <andreymyssak@gmail.com>
Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
Signed-off-by: Sergey Myssak <sergey.myssak@gmail.com>
Signed-off-by: Miki <miki@amazon.com>
Signed-off-by: Sirazh Gabdullin <sirazh.gabdullin@nu.edu.kz>
Signed-off-by: manasvinibs <manasvis@amazon.com>
Signed-off-by: Kroosh Crusius <kroosh@amazon.com>
Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
Signed-off-by: Aigerim Suleimenova <aigerim.suleimenova27@gmail.com>
Co-authored-by: Matt Provost <provomat@amazon.com>
Co-authored-by: Abhishek Reddy <62020972+AbhishekReddy1127@users.noreply.github.com>
Co-authored-by: Sean Neumann <1413295+seanneumann@users.noreply.github.com>
Co-authored-by: Andrey Myssak <40265277+andreymyssak@users.noreply.github.com>
Co-authored-by: Sergey Myssak <sergey.myssak@gmail.com>
Co-authored-by: Ashwin P Chandran <ashwinpc1993@gmail.com>
Co-authored-by: Andrey Myssak <andreymyssak@gmail.com>
Co-authored-by: Sirazh Gabdullin <sirazh.gabdullin@nu.edu.kz>
Co-authored-by: Manasvini B Suryanarayana <manasvis@amazon.com>
Co-authored-by: Kroosh <kroosh@amazon.com>
Co-authored-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>
Co-authored-by: Aigerim Suleimenova <aigerim.suleimenova27@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCI College Contributor Initiative
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants