Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address core refactor changes #522

Merged
merged 1 commit into from
Aug 13, 2023
Merged

Conversation

khushbr
Copy link
Collaborator

@khushbr khushbr commented Aug 12, 2023

Is your feature request related to a problem? Please provide an existing Issue # , or describe.
Multiple refactoring changes in core including:

  1. opensearch-project/OpenSearch@e354201
  2. opensearch-project/OpenSearch@de2b6b7

Describe the solution you are proposing
Accommodate the refactoring changes in downstream PA plugin

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Khushboo Rajput <khushbr@amazon.com>
@khushbr khushbr changed the title Address core changes Address core refactor changes Aug 12, 2023
@codecov
Copy link

codecov bot commented Aug 12, 2023

Codecov Report

Merging #522 (ccc257e) into main (7d0b5a9) will not change coverage.
Report is 2 commits behind head on main.
The diff coverage is n/a.

❗ Current head ccc257e differs from pull request most recent head 2faa7f6. Consider uploading reports for the commit 2faa7f6 to get more accurate results

@@            Coverage Diff            @@
##               main     #522   +/-   ##
=========================================
  Coverage     73.85%   73.85%           
  Complexity      381      381           
=========================================
  Files            45       45           
  Lines          2693     2693           
  Branches        172      172           
=========================================
  Hits           1989     1989           
  Misses          596      596           
  Partials        108      108           
Files Changed Coverage Δ
...earch/performanceanalyzer/OpenSearchResources.java 97.36% <ø> (ø)
...performanceanalyzer/PerformanceAnalyzerPlugin.java 77.14% <ø> (ø)
...alyzer/action/PerformanceAnalyzerActionFilter.java 96.87% <ø> (ø)
...yzer/action/PerformanceAnalyzerActionListener.java 96.87% <ø> (ø)
...ceanalyzer/collectors/CircuitBreakerCollector.java 94.28% <ø> (ø)
...collectors/NodeStatsAllShardsMetricsCollector.java 91.15% <ø> (ø)
...llectors/NodeStatsFixedShardsMetricsCollector.java 92.70% <ø> (ø)
...nalyzer/config/setting/ClusterSettingsManager.java 5.88% <ø> (ø)
...config/PerformanceAnalyzerClusterConfigAction.java 85.96% <ø> (ø)
...action/config/PerformanceAnalyzerConfigAction.java 93.18% <ø> (ø)
... and 8 more

@khushbr khushbr merged commit 2046483 into opensearch-project:main Aug 13, 2023
5 of 7 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 13, 2023
Signed-off-by: Khushboo Rajput <khushbr@amazon.com>
(cherry picked from commit 2046483)
khushbr added a commit that referenced this pull request Sep 5, 2023
Signed-off-by: Khushboo Rajput <khushbr@amazon.com>
(cherry picked from commit 2046483)

Co-authored-by: Khushboo Rajput <59671881+khushbr@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants