Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] changes to merge PA-RTF #662

Merged
merged 2 commits into from
Jun 11, 2024

Conversation

devagarwal1803
Copy link

@devagarwal1803 devagarwal1803 commented Jun 11, 2024

backport of #651
Is your feature request related to a problem? Please provide an existing Issue # , or describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you are proposing
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

Check List

  • Backport Labels added.
  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

* PA RTF merging init

Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com>

* working model

Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com>

* working model tip

Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com>

* functional model init

Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com>

* Migrated HeapMetricsCollector

Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com>

* Added RTFThreadPoolMetricsCollector

Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com>

* migrated NodeStats and DiskMetricsCollector

Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com>

* Added gauge data model for Heap_Max metric

Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com>

* implemented TelemetryAwarePlugin

Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com>

* Framework changes for PA RTF merging

Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com>

* refactored

Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com>

* spotless applied

Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com>

* Addressed small comments

Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com>

* Added different flag for RCA collectors

Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com>

* Addressed more comments

Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com>

* Added RTF collectors in config map

Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com>

* Added UTs

Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com>

* Added further UTs

Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com>

* Added dynamic control support to all collectors

Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com>

* fixed UT

Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com>

* refactoring

Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com>

* Revert "refactoring"

This reverts commit 25d66e8.

Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com>

* Revert "fixed UT"

This reverts commit 369bd95.

Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com>

* Revert "Added dynamic control support to all collectors"

This reverts commit 447e15f.

Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com>

* Adding two new collector interfaces

Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com>

* simplified interfaces

Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com>

* Added units and javadocs

Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com>

* Changes metrics semantic conventions

Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com>

* refactored

Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com>

* fixed UT

Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com>

* Added stats metrics for rtf collectors

Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com>

* reverted test delete

Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com>

* Fixes javadoc compilation issue

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

---------

Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com>
Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
Co-authored-by: Gagan Juneja <gjjuneja@amazon.com>
@Gaganjuneja Gaganjuneja self-assigned this Jun 11, 2024
Signed-off-by: Dev Agarwal <devagarw@amazon.com>
@nishchay21 nishchay21 merged commit 84379d5 into opensearch-project:2.x Jun 11, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants