Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Pass environment setting to personalized setting while cluster is up #171

Merged
merged 1 commit into from
Jul 25, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link

Backport 20a30fd from #169

…169)

* pass environment setting to personalized setting  while cluster is up

Signed-off-by: Mingshi Liu <mingshl@amazon.com>

* add test coverage

Signed-off-by: Mingshi Liu <mingshl@amazon.com>

---------

Signed-off-by: Mingshi Liu <mingshl@amazon.com>
(cherry picked from commit 20a30fd)
@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Merging #171 (4c2a0e0) into 2.x (4bc0ea9) will decrease coverage by 0.11%.
The diff coverage is 25.00%.

@@             Coverage Diff              @@
##                2.x     #171      +/-   ##
============================================
- Coverage     83.44%   83.33%   -0.11%     
- Complexity      331      333       +2     
============================================
  Files            42       42              
  Lines          1250     1254       +4     
  Branches        153      153              
============================================
+ Hits           1043     1045       +2     
- Misses          130      132       +2     
  Partials         77       77              
Files Changed Coverage Δ
...search/search/relevance/SearchRelevancePlugin.java 0.00% <0.00%> (ø)
...igentranking/client/PersonalizeClientSettings.java 96.66% <100.00%> (+0.11%) ⬆️

... and 1 file with indirect coverage changes

@sejli sejli merged commit 47e5a51 into 2.x Jul 25, 2023
12 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants