Helper script for quickstart setup of Personalize plugin #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Description: Helper script is intended for quick start setup of OpenSearch. Script does following: * Build containers for both opensearch and opensearch dashboard * Picks up credentials from given profile or environment variable or default profile and stores them in opensearch keystore if available. * Gets both opensearch and opensearch dashboard up and running Signed-off-by: Ketan Kulkarni <kektnr@amazon.com>
Codecov Report
@@ Coverage Diff @@
## main #177 +/- ##
=========================================
Coverage 83.33% 83.33%
Complexity 333 333
=========================================
Files 42 42
Lines 1254 1254
Branches 153 153
=========================================
Hits 1045 1045
Misses 132 132
Partials 77 77 |
kulket
requested review from
msfroh,
macohen,
noCharger,
mingshl and
sejli
as code owners
mingshl
reviewed
Jul 21, 2023
|
|
||
| # Some useful constants | ||
| readonly DOCKER_IMAGE_TAG="opensearch-with-personalized-search-ranking" | ||
| readonly OPENSEARCH_VERSION="2.9.0" |
There was a problem hiding this comment.
if hard coded the version, in the following version upgrade, you will need to bump the version here, and also you are not able to run the script in main with 3.0.0.
Suggested to read the version number from the build.gradle file here
There was a problem hiding this comment.
After current release, I am actually planning to update OPENSEARCH_VERSION to use tag value latest instead of any specific version in order to always use latest publicly available version.
Since this script depends upon availability of container image I don't think havning future release value like 3.0.0 is feasible.
Please let me know if I am missing something as well as if it is ok to update tag value to latest as a follow up change once v 2.9.0 is released.
mingshl
approved these changes
Jul 24, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 24, 2023
### Description: Helper script is intended for quick start setup of OpenSearch. Script does following: * Build containers for both opensearch and opensearch dashboard * Picks up credentials from given profile or environment variable or default profile and stores them in opensearch keystore if available. * Gets both opensearch and opensearch dashboard up and running Signed-off-by: Ketan Kulkarni <kektnr@amazon.com> (cherry picked from commit 83c8301)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 24, 2023
### Description: Helper script is intended for quick start setup of OpenSearch. Script does following: * Build containers for both opensearch and opensearch dashboard * Picks up credentials from given profile or environment variable or default profile and stores them in opensearch keystore if available. * Gets both opensearch and opensearch dashboard up and running Signed-off-by: Ketan Kulkarni <kektnr@amazon.com> (cherry picked from commit 83c8301)
mingshl
pushed a commit
that referenced
this pull request
Jul 24, 2023
### Description: Helper script is intended for quick start setup of OpenSearch. Script does following: * Build containers for both opensearch and opensearch dashboard * Picks up credentials from given profile or environment variable or default profile and stores them in opensearch keystore if available. * Gets both opensearch and opensearch dashboard up and running Signed-off-by: Ketan Kulkarni <kektnr@amazon.com> (cherry picked from commit 83c8301) Co-authored-by: kulket <130191298+kulket@users.noreply.github.com>
sejli
pushed a commit
that referenced
this pull request
Jul 25, 2023
### Description: Helper script is intended for quick start setup of OpenSearch. Script does following: * Build containers for both opensearch and opensearch dashboard * Picks up credentials from given profile or environment variable or default profile and stores them in opensearch keystore if available. * Gets both opensearch and opensearch dashboard up and running Signed-off-by: Ketan Kulkarni <kektnr@amazon.com> (cherry picked from commit 83c8301) Co-authored-by: kulket <130191298+kulket@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Helper script is intended for quick start setup for OpenSearch. Script does following:
opensearchandopensearch dashboardopensearchandopensearch dashboardup and runningCheck List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.