[Backport 2.9] Reject Personalize processor in ad hoc pipeline #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
If we create a search pipeline as part of a search request, each processor gets created as part of the search request. Since the Amazon Personalize ranking processor creates a client (with a connection pool and credential provider), this could get expensive if someone sends a flurry of search requests with inline (ad hoc) pipelines. Also, when a pipeline is created, we create each processor as a way of validating the configuration. At that point, we don't need to initialize the Personalize client, since that processor will just get garbage-collected. Signed-off-by: Michael Froh <froh@amazon.com> (cherry picked from commit 64355c7)
Codecov Report
@@ Coverage Diff @@
## 2.9 #186 +/- ##
============================================
+ Coverage 83.33% 83.39% +0.06%
- Complexity 333 334 +1
============================================
Files 42 42
Lines 1254 1259 +5
Branches 153 154 +1
============================================
+ Hits 1045 1050 +5
Misses 132 132
Partials 77 77
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 64355c7 from #183